I got the same problem with theme check plugin. But I found that it’s not my theme, it’s node_module folder of grunt. When I removed it, theme check worked well. I guess that it’s related to translation string. Hope my solution can help other people.
In some ways, it makes the most sense to use Theme Check to test a theme that’s been prepared for release, rather than while it’s still in development. (e.g. the `build` rather than the `src`.)
So you wouldn’t have `node_modules` in `build` anyway.
Great news! Looks like John has managed to get his campaign fully funded, he mentions in Update #3 on his blog.
Thanks so much to everyone from ThemeForest and Envato who contributed. John’s a top guy, and I’m excited to see what he can do with BuddyPress, bbPress, and GlotPress now that he’s been liberated to really focus on them.
Thanks for sharing. I wouldn’t have known about the campaign otherwise and I love those projects. I’ve added a small amount too, I hope it helps
I know a number of authors on ThemeForest (and perhaps CodeCanyon too) use BuddyPress and/or bbPress for their support forums. And I think we all benefit from GlotPress allowing WordPress to be translated into all different languages
Hello wonderful ThemeForest authors!
I’m not sure how many of you use BuddyPress, bbPress, or GlotPress regularly, but I know some of you do, and I thought you might like to know (if you didn’t already) there’s an opportunity to support development of these fantastic open source projects.
John James Jacoby (@JJJ), who’s been the project lead for BuddyPress and bbPress since 2010, is running an IndieGoGo campaign to fund full-time work on these projects in 2015. He’s very close to reaching his goal amount already, and there are 10 days left of the campaign.
You can read more from the IndieGoGo campaign itself here: http://igg.me/at/jjj/x/744233
Thanks for reading! I know some of you have already supported this campaign, and I hope more of you might be able to as well
Disclaimer: I have no personal investment in this campaign, other than wanting to see a talented individual empowered to work on important projects.
If this post is against any of the guidelines of the forums, my humble apologies. I read them thoroughly, and couldn’t see anything prohibiting posting this. I also did a search to check for precedents, and it seems this is fine. If you have an issue with it, please contact me directly.
When you submit your theme to the Review Team, do you bundle all plugins within it? By this I mean both third party and your own custom ones?
OR…Do you only include your own and provide references within your documentation that explain to the customer where to download the third party plugin(s) (e.g. Contact Form 7).
As mentioned in the WordPress Theme Submission Requirements, it’s encouraged that you use something like the TGM Plugin Activation class to prompt users to install both third-party and bundled plugins.
In this case, for plugins that are hosted on the WordPress.org plugin directory, there’s no need to include them in your theme, as TGMPA can simply install them direct from WordPress.org.
Does that make sense?
Just for info :
Recently received 2 star rating for my theme with main reason that theme needs multiple plugin to get it work .Out of 4 basically required plugins two are for slider and page builder. Other two are made according to phase 2 requirement (for shortcodes and CPT). I’m aware, phase 2 is not finalized yet, still did so just to avoid extra work when new guidelines are enforced.
Assuming we’re talking about your most recent theme, you have 5 required plugins and 3 recommended plugins.
I very much appreciate you embracing the idea of moving functionality into plugins.
The feedback you’ve gotten from this particular customer is definitely unfortunate. I think it’s likely more a reflection of what the customer has become accustomed to than anything else, which is something we need to deal with as we progress.
It would be good also if we could find a better way of handling the dependency installation than the TGM Plugin Activation class. Something that guides the customer through the process better.
For example, a change of terminology perhaps? “Enable or Disable X Functionality”, the customer shouldn’t need to care if it’s in a plugin or not, that’s for the developer to care about.