Posts by Japh

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

Can you please explain how lists in TinyMCE is a shortcode? All I am saying here is, Lists is a standard feature in Tiny MCE editor, why should there be a shortcode for this in the first place? and How can this be admissible ?
It is like creating a shortcode for Headings (H1,H2…) and it is in the admissible list. I am merely pointing the inconsistency that I feel here.

Thanks for clarifying! I’ll discuss this further with the review team.



Not allowing one plugin doesn’t mean not allowing all plugins.
The question was about the same plugin.

Perhaps I misunderstood your first post? I thought you were saying “You aren’t allow to include plugins in your theme at all”, but perhaps you actually meant “Not all plugins will be allowed to be included”?


It’s a commercial plugin. Buyers cannot auto update it. More, when i first released the theme buyers went and bought the plugin even if it was included, because thought that they should do so in order to update. But this is wrong, since i’ve modified the plugin a lot. So now, i have my own version of the plugin which i only update on theme updates and the buyers have to update both the theme and the plugins. Otherwise they could simply update the theme and the plugin should be update.

Well this is an interesting grey area isn’t it. You’ve forked a plugin, and can now only offer updates via theme inclusion?

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

Really?! I’ve included the Visual Composer in my latest theme and i was bashed by the reviewers one whole week because i’ve included the Visual Composer in my theme, which was actually possible since the author of the plugin already gave the tools for doing this. Finally the reviewers told that they will not accept the theme unless i put the plugin inside the TGM activation class, which was stupid, because the plugin is completely modified by me, so now buyers have a really hard time to update and maintain it. Yes, it’s harder to maintain a plugin installed via TGM then a plugin embedded in the theme. You may say otherwise, but you’re not the one who is answering my support tickets :)

Not allowing one plugin doesn’t mean not allowing all plugins.

Also, maintenance should be easier with TGMPA. If it’s not working better for you, I’d be interested to know why. Keeping the plugin separate for updates means the plugin can be updated independently of the theme, which is great.

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

WordPress Core API
1. base64_encode() : This is not allowed in a theme, but is it allowed in plugins ? It is being used by popular plugins to import/export settings.

Actually we’re saying this is ok. Normally Theme-Check will throw an error, but we’re allowing it for certain conditions, such as theme frameworks that need it, etc.


WordPress Features
1. Admissible shortcodes list is contentious.
a. Lists is already in WP Editor Tiny MCE, but it is in admissible shortcode whereas Accordion/Toggles are not.
b. What about other common shortcodes like Tabs, Icons etc.

Can you please explain how lists in TinyMCE is a shortcode?


2. Columns shortcodes (in one form or other) are being used by Themes with inbuilt PageBuilder. So, do they have to move out their inbuilt PageBuilder as a separate plugin?

I would imagine that’s one way to resolve the issue, yes.


HTML/CSS
1. W3C Validated, Is it necessary ? Twenty twelve has 12 errors.
2. No Inlines styles? But Inline styles are added by the WP Tiny MCE editor when you try to give text a color or center align the text etc..

As WordPress is doing it there, there isn’t much that can be done, but it’s undesirable behaviour.


Another important question is :
Themeforest API updates the Theme what about the plugins included in the theme using TGI Activation ?

Plugins will need to have their own individual update mechanism. This is one of the issues we’re trying to resolve with this.

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

You are not allowed to include absolutely any plugins in the theme. But you can create your own version and give that to buyers.. And you can include all shortcodes with that..

Actually, we haven’t said you can’t include any plugins with your theme.

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

What about Option Tree? It throws errors in the theme check..

Hey Ruben! Check out the latest version of OptionTree, you’ll find it’s much better at this.

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

I’m using reCAPTCHA library in a theme which uses base64_encode, fwrite, fsockopen and fclose. Is it allowed to use it reCAPTCHA library?

In my opinion, it is not possible and it should not be required to eliminate the info messages.

You will get INFO messages for the following cases:

1. If you place link to your website in theme options or anywhere in the backend so that user knows where to get support.

2. If you use ANY iframe. ALL social buttons, videos and other embedded media uses the iFrames.

Even the wordpress.org official theme directory does not require to eliminate the INFO messages.

We want you to eliminate them as much as possible, and anything remaining, will be left to the reviewer’s discretion. But you’ll know that if they are left over, there’s a chance it’ll be a problem for approval.


One more thing, WP Core API #12:

The text domain parameter must be a string and not a variable or constant.

Is this for the text string or the text domain parameter? As theme-check doesn’t throw any errors if only the text_domain that is using a constant/variable.

This is for specifying the text domain parameter.

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

The question is, is it allowed to make my own core functionality plugin (like this one here: http://www.billerickson.net/core-functionality-plugin/), that accepts my other set of plugins as its components. The components then, will not work without firstly installing the core plugin as they depends on hooks of the core plugin.

There’s no problem using a core plugin that can be extended by other plugins. Many other plugins do this.


One more question, so theme options framework like NHP or SMOF is no longer allowed as they are not plugins but more of a framework we need to include?

I don’t see any reason why you couldn’t use a theme options framework, providing your theme still passes the requirements :)

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

Buttons, dropcaps, lists shortcodes should be inadmissible shortcodes to follow this suggestion http://justintadlock.com/archives/2011/05/02/dealing-with-shortcode-madness from JustinTadlock.

I’ll discuss this further with the review team. Thanks for the link!

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

Quick query about #6 under PHP. Can we use the more verbose, but clearer, endwhile, endif, endforeach, etc in template files? I use curly braces in all the non-template files, but avoid those in template files as I think the alternative is much more obvious to someone who doesn’t know PHP.

Yes, absolutely. This guidelines is referring to this situation:

// Not very readable
if ( empty( $variable ) )
    return;

// Much better!
if ( empty( $variable ) ) {
    return;
}

Could you please re-check again about admissible and inadmissible shortcodes?

I see buttons, dropcaps, and lists are admissible shortcodes, but columns, maps, and contact forms are inadmissible shortcodes….

Switched? Are you sure?

Sorry, I’m not exactly sure what you’re asking?


Quick one regarding the Theme Check feedback. include_once is permissible, but require_once, require and include aren’t allowed. Is that correct?

I imagine they would be, for the same reasons. It will be on a case-by-case basis at the reviewer’s discretion.

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

Great, standards are always great.

Thanks! :D


* Inadmissible shortcodes, all the listed ones can be added using a plugin, right?

Yes, shortcodes are best living in plugins, not themes.


* All HTML needs to be validated via the W3C validator. – will this be MANDATORY to whole theme? Sometimes at demo, you need use a style switcher, that usually will create warnings at validator, can you be more specific about validation, please?

My understanding is that this will be the theme itself. Will get clarification for you though.


* No inline styles are allowed any where – this means we can’t use style attribute or <style type=”text/css”></style> in our code, even when necessary? If we use a plugin to provide shortcodes, the plugin can add these inline styles, right?

Inline styles are the ‘style=””’ attribute. Plugins can enqueue stylesheets, etc.


* TGM Plugin Activation requires that the plugin stay inside theme folder? If we send the plugins (to shortcodes, portfolio and other things) in a separated folder and explain how to install the plugins that user want only – will we be rejected? Some plugins have 2MB or more, including inside theme folder would increase a lot theme package size, can you please clarify it?

That sounds fine to me, but I’ll get confirmation for you from the review team.

by
by
by
by
by
by