Posts by JonnyShogun

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says


Regarding widgets, I have placed all my custom widgets into a plugin.. But i have 3 widgets that i made that are dependent on data from my admin options. My contact info widget, my social widget, and my twitter widget. Basically in the widgets page the user just drags the widget over to the position they want it in, and the configuration info is in my admin options page, with links in those widgets displaing links to my admin page to configure. So those widgets i didn’t include in the plugin since they depend on data that is specific to the admin options i have in my theme. And those widgets share files that only available in my theme so i dont have duplicate code.

Will that be Ok, that these widgets are not included with my other widgets inside a plugin since the info from those widgets are dependent from my themes admin options?

This would be at the discretion of the reviewer. It’s difficult to answer this one, as I don’t know why your Twitter widget would be dependent on your admin options.

basically when a user sets the Twitter Widget ID in the admin in one place, versus having to put that Twitter Widget ID in a input field in every Twitter Widget block.



Any thoughts on what would stop another developer or user from stealing code from the easy accessible plugins? And do we have to make all slider options into a plugin?

Can you explain a little further the scenario you imagine them getting access to the plugins?

I can think of two possibilities:

  1. File access to the theme or WordPress install, and taking the plugins
    If they have this level of access, nothing is stopping them doing that now.
  2. URL access to ZIP file of plugins in the theme’s subdirectory
    An option would be to utilise a different method of distribution. Have the theme install the required plugins, via TGMPA (or similar), from a repository or server that requires a key. Soon, CodeCanyon will support this (as ThemeForest does), for example.

i can see how both possibilities they can do now, but it looks like that making the slider options into a plugin, just make it easier for people to just grab your code since now its portable via a plugin

I already am using TGMPA. How would you make it available on a server with a key?

Also what the point on making slider options into a plugin, when a user can not use it on another theme, since all the files for it to work on the frontend are in the theme itself??

thanks again JAPH !!

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says


Regarding widgets, I have placed all my custom widgets into a plugin.. But i have 3 widgets that i made that are dependent on data from my admin options. My contact info widget, my social widget, and my twitter widget. Basically in the widgets page the user just drags the widget over to the position they want it in, and the configuration info is in my admin options page, with links in those widgets displaing links to my admin page to configure. So those widgets i didn’t include in the plugin since they depend on data that is specific to the admin options i have in my theme. And those widgets share files that only available in my theme so i dont have duplicate code.

Will that be Ok, that these widgets are not included with my other widgets inside a plugin since the info from those widgets are dependent from my themes admin options?

This would be at the discretion of the reviewer. It’s difficult to answer this one, as I don’t know why your Twitter widget would be dependent on your admin options.

basically when a user sets the Twitter Widget ID in the admin in one place, versus having to put that Twitter Widget ID in a input field in every Twitter Widget block.

also regarding my previous comment about:

What is going to stop another developer or user from stealing your code that you put in a plugin, and use it in another Theme? So all your hard work can be easily stolen by making all these fetures of your theme made into a plugin? This is very troubling, How will we be protected from this? And how will Admin Slider Options be treated, if my slider options are made into a plugin? ...they can easily be available for use in someones theme, and is ripe fro misuse!

Any thoughts on what would stop another developer or user from stealing code from the easy accessible plugins? And do we have to make all slider options into a plugin?

Thanks again JAPH for answering our questions so fast!! :)

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says

What is going to stop another developer or user from stealing your code that you put in a plugin, and use it in another Theme? So all your hard work can be easily stolen by making all these fetures of your theme made into a plugin? This is very troubling, How will we be protected from this?

And how will Admin Slider Options be treated, if my slider options are made into a plugin? ...they can easily be available for use in someones theme, and is ripe fro misuse!

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says

Hello,

Regarding widgets, I have placed all my custom widgets into a plugin.. But i have 3 widgets that i made that are dependent on data from my admin options. My contact info widget, my social widget, and my twitter widget. Basically in the widgets page the user just drags the widget over to the position they want it in, and the configuration info is in my admin options page, with links in those widgets displaing links to my admin page to configure. So those widgets i didn’t include in the plugin since they depend on data that is specific to the admin options i have in my theme. And those widgets share files that only available in my theme so i dont have duplicate code.

Will that be Ok, that these widgets are not included with my other widgets inside a plugin since the info from those widgets are dependent from my themes admin options?

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says


Great Japh ! I’ve spent few days to solve the issue with new twitter API a month ago, updated all the themes since I have the option even with a shortcode and separate widget also… And now the things are changing again?... A separate plugin only for twitter which should not use cURL? Thanks guys… seems that all my work and another author’s here was for nothing…

I’m sure your work hasn’t been for nothing. You need only must remove cURL from your theme. Moving the Twitter functionality into a plugin will achieve that.

It would be much better to use wp_remote_request() instead of cURL, but that’s not strictly a part of these requirements.

So basically when you say put taht functionality into a plugin.. does that mean i have to make a wp plugin for each thing. Like creating a plugin for just shortcodes, a plugin for custom post types, and a plugin for twitter api. Cant i just have all these in ONE plugin?

thanks!

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says


What about the new Twitter API oAuth.. it uses curl. So what do we do about that since the new Twitter API since in order to use the new twitter requests, you must use there new API oAth files. You have to setup a Twitter developer app to use with the new Twitter APi which uses curl. So will this be a problem???
You’re referring to example PHP files, which can be modified for use in a WordPress context, and will work just fine. Even so, this functionality should be in a plugin.

So are you basically saying that i would have to include this twitter functionality as a plugin, right?

And i would have to modify the twitter oAuth 1.1 php to not use curl?

thanks again for the quick reply!

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says


Your themecheck plugin doesn’t supress the usage of cURL. Is that intended?
Yes, that is intended. Instead of using cURL, you should use WordPress’ wp_remote_request() function.

What about the new Twitter API oAuth.. it uses curl. So what do we do about that since the new Twitter API since in order to use the new twitter requests, you must use there new API oAth files. You have to setup a Twitter developer app to use with the new Twitter APi which uses curl. So will this be a problem???

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says

This thread should 100% be locked. A lot of authors have already spoken and asked most questions that needed to be asked at this stage. Lock it and start a new one when the guidelines have been revised.

i totally agree.. too many people are using this thread to ask their “how to do this and that”. Envato Staff said to hold on to any more replies until they post the New Revised Wordpress Theme Submission Guidelines. I don’t think people on here know how to read and wait!

It would be cool if the new Revised guidelines are started in a new thread to prevent confusion for the guidelines. Envato, please LOCK this thread until the revised guidelines are posted!

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says

Looks like this thread is being taking over on how to do specific things (ie.. menu order, etc..) . Instead of posting questions or concerns regarding the Topic on hand, about the New Wordpress Theme Guidelines. Those questions on how to do certain things should be started in a new thread, so we don’t have to clutter this thread up with how to’s.

This thread is large enough, Lets stay on Topic guys!

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says

I don’t see the purpose of having only certain shortcodes being made into wp plugin. And like other people have said on this post. All it will do is allow other developers and users to mish-mosh .. mix and match your plugins and make a Mr Potato theme out of all your hard work.

Whats gonna stop other authors or users from using your plugins in their own themes, and then you get no compensation ???

by
by
by
by
by
by