Posts by JonnyShogun

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says

I have to tell that I’m strict agains this rulle “No inline styles are allowed any where.”.

I think they mean you can’t have any inline styles on the source code before it runs in the browser. Javascript/jQuery and DOM scripting will manipulate the DOM and add inline styles when performing various tasks to do whatever your changing. For example.. for showing and hiding elements, inline styles of display:block and display:none will be applied on the style attribute of the tag your showing and hiding.

So I believe that they don’t what inline styles all over your source code, which is understandable so your source code keeps with standards and readability.

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says


I notice that in the Theme Check plugin when running tests, it displays that it is REQUIRED for add_theme_page() to be used in place of add_menu_page().

I’m not understanding why add_menu_page() is REQUIRED instead of RECOMMENDED? Since add_menu_page() adds a top level menu item, whereas add_theme_page() only adds a submenu under the Appearance top level menu. Why does the Theme Check plugin have this as REQUIRED instead of RECOMMENDED, when WordPress Codex has that method available for wp developers to use? And the various themes sold on ThemeForest have top level menu items to group and organize their option page menus for usability to the end user.

If my admin options I’m making for a theme have many option pages, I want to group my theme pages together under my own top level menu item. It will be very impractical to use add_theme_page(), which would make all my option pages submenus under the Appearance menu. I want to group my option pages together so the end user doesn’t get confused when using my theme and navigating the backend which is a usability issue! That is why i would use add_menu_page().

Anyone else seeing this error thrown in the Theme Check plugin? And think that it should be RECOMMENDED instead of REQUIRED?

I emailed Enavto Support regarding this issue with the Theme Check plugin, and will post if I receive an answer.

thanks!

Absolutely!!

If wordpress does not let developers use top level menu then where is the scalability of wordpress we all talking about? why all of my pages should go under appearance?

Do you know why theme check gives this error? because its configured for wordpress.com where you cant do much. they have this and that rules for their own…

I wrote the author about that Theme Check plugin, and he basically said that ThemeForest rules don’t apply to his plugin, and at themes being submitted to wordpress.org. http://wordpress.org/support/topic/regarding-why-add_menu_page-is-required-instead-of-recommenced

So why do we have to use the Theme Check plugin, that enforces different errors and rules for the way to submit themes on wordpress.org. When we are submitting themes to ThemeForest?

ThemeForest should make their own Theme Check plugin for checking themes submitted on ThemeForest. Instead of being forced to use the Theme Check plugin that was built to submit themes on Wordpress.org.

This makes no sense for his Theme Check plugin to say that add_menu_page() be replaced with add_theme_page(). Even on the wordpress codex examples for creating options pages, it uses add_menu_page() :

http://codex.wordpress.org/Creating_Options_Pages

What do you all of you think of that Theme Check plugin?

33 posts
  • Has been part of the Envato Community for over 2 years
  • Has collected 1+ items on Envato Market
  • Sells items exclusively on Envato Market
  • Located in United States
JonnyShogun says

I notice that in the Theme Check plugin when running tests, it displays that it is REQUIRED for add_theme_page() to be used in place of add_menu_page().

I’m not understanding why add_menu_page() is REQUIRED instead of RECOMMENDED? Since add_menu_page() adds a top level menu item, whereas add_theme_page() only adds a submenu under the Appearance top level menu. Why does the Theme Check plugin have this as REQUIRED instead of RECOMMENDED, when WordPress Codex has that method available for wp developers to use? And the various themes sold on ThemeForest have top level menu items to group and organize their option page menus for usability to the end user.

If my admin options I’m making for a theme have many option pages, I want to group my theme pages together under my own top level menu item. It will be very impractical to use add_theme_page(), which would make all my option pages submenus under the Appearance menu. I want to group my option pages together so the end user doesn’t get confused when using my theme and navigating the backend which is a usability issue! That is why i would use add_menu_page().

Anyone else seeing this error thrown in the Theme Check plugin? And think that it should be RECOMMENDED instead of REQUIRED?

I emailed Enavto Support regarding this issue with the Theme Check plugin, and will post if I receive an answer.

thanks!

by
by
by
by
by
by