Done, when do I get my survey ninja badge?
I actually love your theme design very much. I’m a big fan of minimal designs like yours so high five.Issues in my opinion:
- Images in homepage carousel are not resized (you load full version instead of cropped ones) causing unnecessary long page loading
- Contact form button is an image (how are users supposed to translate that?)
- Contact page is too simple and does not look as good as the rest of the layout (maybe incorporate google map somewhere, that’s pretty much standard these days).
- Button shortcode (first in line, the grey one) has white text on hover making it impossible to read the button text
And my last sugestion would be to implement few more layouts for blog/portfolio, for example with single column ot three columns.
OriginalEXE saidMy theme has a static width, and that’s the point, not every user knows about row-fluid so it won’t be just switching themes to make the plugins portable.
nagaemas saidWhy don’t you use row-fluid?
You’ll get a mess, for example Bootstrap columns on Twenty Eleven won’t fit in its main container as a row on Bootstrap is 1200px, the columns will overflow/vertically stacked.
I understand but can’t you still use row-fluid?
It’s not like .row is deciding on your container width so switching it for row-fluid should change nothing.
Well the way I’ll do it is if my theme is not used, but plugin is, only cpt’s and meta fields will be displayed, as well as shortcodes parsed in content, but nothing else.
Another thing to point out is the required use of “
What if a theme only needs to echo the thumbnail url, and not the complete.. then Theme Check will say “
<img src="url" />? If something like this is used to get the url only:
<?php $image_id = get_post_thumbnail_id(); $image_url = wp_get_attachment_image_src($image_id,'large', true); echo $image_url; ?>
get_post_thumbnail” is not used… Unless someone knows a better way to do the above, this should probably be under the exceptions as well.
Maybe like this
if ( false ) the_post_thumbnail();
Just kidding, but yeah, it should not be required.
really some points good , but others need more discussions about that.
my ask now :thanks.
are all this Requirements for our old themes , or just new themes .. ?
i mean , should update old themes to be okay with all this Requirements ..? or not ?
Yes you should but as they said, you will have much more time (undefined, but in months) to standarize the old themes.
carlhancock saidNo need for shortcode, take a look at this: https://gist.github.com/bitfade/4555047 by @bitfade
Same goes for dealing with autop, it can be set to be used only on custom defined shortcodes and not globally.
I have yet to see a RAW or NOFORMAT shortcode to disable autop that didn’t have a global impact.
YES you can create a shortcode that content contained within it does not have autop applied to it.
But because of how you must implement the code necessary to do this, it changes the order in which functionality in WordPress is executed and while content within the shortcode does not have autop applied to it, it will now apply autop to ALL shortcode output.
By default WordPress dot not apply autop to shortcode output. S when this change is made it can cause proble s for plugins that don’t expect their shortcode output to have autop applied to it,This is why the new guidelines specifically mention you can’t make modifications to WordPress core functionality related to wptexturize and wpautop. Precisely because of the issue I describe above.
Regarding column shortocde, I really don’t understand why it needs to mess with filters for it’s functionality?