Posts by OriginalEXE

1466 posts
  • Has been a member for 2-3 years
  • Exclusive Author
  • Sold between 10 000 and 50 000 dollars
  • Bought between 10 and 49 items
  • Referred between 1 and 9 users
  • Croatia
OriginalEXE says

Hi there,

I actually love your theme design very much. I’m a big fan of minimal designs like yours so high five.

Issues in my opinion:
  1. Images in homepage carousel are not resized (you load full version instead of cropped ones) causing unnecessary long page loading
  2. http://wpvault.com/louatie/our-pictures-will-become-old-photographs/
  3. Contact form button is an image (how are users supposed to translate that?)
  4. Contact page is too simple and does not look as good as the rest of the layout (maybe incorporate google map somewhere, that’s pretty much standard these days).
  5. Button shortcode (first in line, the grey one) has white text on hover making it impossible to read the button text

And my last sugestion would be to implement few more layouts for blog/portfolio, for example with single column ot three columns.

Good luck

1466 posts
  • Has been a member for 2-3 years
  • Exclusive Author
  • Sold between 10 000 and 50 000 dollars
  • Bought between 10 and 49 items
  • Referred between 1 and 9 users
  • Croatia
OriginalEXE says



You’ll get a mess, for example Bootstrap columns on Twenty Eleven won’t fit in its main container as a row on Bootstrap is 1200px, the columns will overflow/vertically stacked.
Why don’t you use row-fluid?
My theme has a static width, and that’s the point, not every user knows about row-fluid so it won’t be just switching themes to make the plugins portable.

I understand but can’t you still use row-fluid?

It’s not like .row is deciding on your container width so switching it for row-fluid should change nothing.

1466 posts
  • Has been a member for 2-3 years
  • Exclusive Author
  • Sold between 10 000 and 50 000 dollars
  • Bought between 10 and 49 items
  • Referred between 1 and 9 users
  • Croatia
OriginalEXE says

You’ll get a mess, for example Bootstrap columns on Twenty Eleven won’t fit in its main container as a row on Bootstrap is 1200px, the columns will overflow/vertically stacked.
Why don’t you use row-fluid?
1466 posts
  • Has been a member for 2-3 years
  • Exclusive Author
  • Sold between 10 000 and 50 000 dollars
  • Bought between 10 and 49 items
  • Referred between 1 and 9 users
  • Croatia
OriginalEXE says

Well the way I’ll do it is if my theme is not used, but plugin is, only cpt’s and meta fields will be displayed, as well as shortcodes parsed in content, but nothing else.

1466 posts
  • Has been a member for 2-3 years
  • Exclusive Author
  • Sold between 10 000 and 50 000 dollars
  • Bought between 10 and 49 items
  • Referred between 1 and 9 users
  • Croatia
OriginalEXE says

Another thing to point out is the required use of “get_post_thumbnail”..

What if a theme only needs to echo the thumbnail url, and not the complete <img src="url" />? If something like this is used to get the url only: <?php $image_id = get_post_thumbnail_id(); $image_url = wp_get_attachment_image_src($image_id,'large', true); echo $image_url[0]; ?>

.. then Theme Check will say “get_post_thumbnail” is not used… Unless someone knows a better way to do the above, this should probably be under the exceptions as well.

Maybe like this :P

if ( false ) 
the_post_thumbnail();

Just kidding, but yeah, it should not be required.

1466 posts
  • Has been a member for 2-3 years
  • Exclusive Author
  • Sold between 10 000 and 50 000 dollars
  • Bought between 10 and 49 items
  • Referred between 1 and 9 users
  • Croatia
OriginalEXE says

really some points good , but others need more discussions about that.

my ask now :
are all this Requirements for our old themes , or just new themes .. ?
i mean , should update old themes to be okay with all this Requirements ..? or not ?

thanks.

Yes you should but as they said, you will have much more time (undefined, but in months) to standarize the old themes.

1466 posts
  • Has been a member for 2-3 years
  • Exclusive Author
  • Sold between 10 000 and 50 000 dollars
  • Bought between 10 and 49 items
  • Referred between 1 and 9 users
  • Croatia
OriginalEXE says


@nagaemas did you check this: https://gist.github.com/bitfade/4555047
Yes I know about this, but I thought this is no longer allowed after this change? Correct me if I’m wrong ;)
It should be since it only affects shortcodes you define and does not mess with filters.
1466 posts
  • Has been a member for 2-3 years
  • Exclusive Author
  • Sold between 10 000 and 50 000 dollars
  • Bought between 10 and 49 items
  • Referred between 1 and 9 users
  • Croatia
OriginalEXE says

@nagaemas did you check this: https://gist.github.com/bitfade/4555047

1466 posts
  • Has been a member for 2-3 years
  • Exclusive Author
  • Sold between 10 000 and 50 000 dollars
  • Bought between 10 and 49 items
  • Referred between 1 and 9 users
  • Croatia
OriginalEXE says


Same goes for dealing with autop, it can be set to be used only on custom defined shortcodes and not globally.

I have yet to see a RAW or NOFORMAT shortcode to disable autop that didn’t have a global impact.

YES you can create a shortcode that content contained within it does not have autop applied to it.

But because of how you must implement the code necessary to do this, it changes the order in which functionality in WordPress is executed and while content within the shortcode does not have autop applied to it, it will now apply autop to ALL shortcode output.

By default WordPress dot not apply autop to shortcode output. S when this change is made it can cause proble s for plugins that don’t expect their shortcode output to have autop applied to it,

This is why the new guidelines specifically mention you can’t make modifications to WordPress core functionality related to wptexturize and wpautop. Precisely because of the issue I describe above.
No need for shortcode, take a look at this: https://gist.github.com/bitfade/4555047 by @bitfade

Regarding column shortocde, I really don’t understand why it needs to mess with filters for it’s functionality?

1466 posts
  • Has been a member for 2-3 years
  • Exclusive Author
  • Sold between 10 000 and 50 000 dollars
  • Bought between 10 and 49 items
  • Referred between 1 and 9 users
  • Croatia
OriginalEXE says


Hey, why does columns shortcode is in Inadmissible list? We have seen on our buyers sites, that they use this shortcode a lot actually and find it very useful.

Why? Because of how it is implemented it typically changes the content output and breaks things such as shortcodes that may be used within one of the columns. Typically in order to implement the columns there is code that manipulated the output.

This manipulation then has unintended consequences. So while the column functionality works great for basic text. It causes problems for other plugins when a user tries to do something like use a shortcode within a column.

This is a great example of theme developer implementing a feature that appears to be great, and users love… only to discover it has major implications down the road because it causes problems with shortcode output for other plugins.

It’s like the RAW or NOFORMAT shortcode that allows you to disable WordPress autop on a block of text in your content using that shortcode. Sure it works and does disable autop on the block of text within that shortcode. But it has the unintended consequence of the. Applying autop to ALL other shortcode output, which WordPress doesn’t do by default. So by introducing a feature, it changes default WordPress behavior in a negative way and breaks other plugins that use shortcodes to output content.

This type of situation is why I’m guessing the columns shortcode is not being allowed anymore. I’m sure they are looking into what types of features seem to cause the most issues and conflicts with plugins, etc.

Apparently some in this thread seem to think Envato is just making up these guidelines out of thin air while I can assure you they wouldn’t be implementing changes like this lightly. They’ve put a lot of time and research into the support issues and conflicts caused by certain functionality and that has contributed a lot to why some things are no longer going to be allowed.

That’s not true, all that column shortcode does is restricts container width, which should be handled by other plugins by using fluid daylotu (we are in responsive era after all).

Same goes for dealing with autop, it can be set to be used only on custom defined shortcodes and not globally.

by
by
by
by
by
by