Posts by ThemeProvince

2597 posts Put a Donk On It
  • Elite Author: Sold more than $75,000 on Envato Market
  • Sells items exclusively on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has sold $250,000+ on Envato Market
+10 more
ThemeProvince
says

So you’re from the UK huh? I’d be happy to help you get your stuff accepted :)

In my own experience quantity and good support wins over the actual quality of the theme in terms of design. That’s my take on things anyway.

2597 posts Put a Donk On It
  • Elite Author: Sold more than $75,000 on Envato Market
  • Sells items exclusively on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has sold $250,000+ on Envato Market
+10 more
ThemeProvince
says

You don’t happen to live in York by any chance? Because I’m pretty sure the people I share an office know you. Its a small world :)

2597 posts Put a Donk On It
  • Elite Author: Sold more than $75,000 on Envato Market
  • Sells items exclusively on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has sold $250,000+ on Envato Market
+10 more
ThemeProvince
says

I guess those are probably not mandatory or too difficult to check reliably. Just take esc_url / esc_attr for example, I don’t think Theme Check can automatically tell when to use which, and whether they are necessary at all. Below is the code snippet taken from header.php from twentyfifteen theme :
$description = get_bloginfo( 'description', 'display' );
if ( $description || is_customize_preview() ) : ?>
    <p class="site-description"><?php echo $description; ?></p>
<?php endif;
ThemeForest reviewers would probably have soft-rejected an item with that code if they found ‘echo $’ because it’s not escaped (although get_bloginfo would have done the validation but it’s not the ‘last step’ in this case), but the WordPress developer team accepts it and is letting millions of user use it as the default theme.

Just out of interest what function would you use to escape $description? esc_html_e?

2597 posts Put a Donk On It
  • Elite Author: Sold more than $75,000 on Envato Market
  • Sells items exclusively on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has sold $250,000+ on Envato Market
+10 more
ThemeProvince
says

So I was wondering if anyone else has noticed that the Theme Check plugin does not cover data validation. It does not look for html attributes or urls without filter functions like esc_url and esc_attr.

You would think since it performs over 100,000 checks this would be one of them.

How strange :/

2597 posts Put a Donk On It
  • Elite Author: Sold more than $75,000 on Envato Market
  • Sells items exclusively on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has sold $250,000+ on Envato Market
+10 more
ThemeProvince
says

OMG YES!!!

2597 posts Put a Donk On It
  • Elite Author: Sold more than $75,000 on Envato Market
  • Sells items exclusively on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has sold $250,000+ on Envato Market
+10 more
ThemeProvince
says

Hi ThemeProvince. Maybe it is not outline but box shadow like this http://prntscr.com/68tzxb

Oh thats what that is. I thought it was the mac’s outline border! Thanks man! :D

2597 posts Put a Donk On It
  • Elite Author: Sold more than $75,000 on Envato Market
  • Sells items exclusively on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has sold $250,000+ on Envato Market
+10 more
ThemeProvince
says

I have tried:

a, a:active, a:focus {
                outline: 0;
            }

HELP!

2597 posts Put a Donk On It
  • Elite Author: Sold more than $75,000 on Envato Market
  • Sells items exclusively on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has sold $250,000+ on Envato Market
+10 more
ThemeProvince
says

John is spelt incorrectly I’m puzzled how you didn’t notice that :D

2597 posts Put a Donk On It
  • Elite Author: Sold more than $75,000 on Envato Market
  • Sells items exclusively on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has sold $250,000+ on Envato Market
+10 more
ThemeProvince
says

NEW VERSION!

I remade my original theme switcher. You can preview it here.

You can download it here: Download

INSTRUCTIONS ARE INSIDE IN A HTML FILE!

G

2597 posts Put a Donk On It
  • Elite Author: Sold more than $75,000 on Envato Market
  • Sells items exclusively on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has sold $250,000+ on Envato Market
+10 more
ThemeProvince
says

But.. but.. you do state it is free AND you are passionate about it…

by
by
by
by
by
by