It’s already fixed in 4.2.1: https://wordpress.org/news/2015/04/wordpress-4-2-1/
This is Awesome news.
Out of curiosity, are you guys using a Payment processor and are all the fraud checks in place? Increased fraud rate is always an issue when accepting cards directly.
It would be great if Envato could expand on the author terms to actually allow edge-cases like this. How would the author possibly sell the external dependencies, not under author’s control, on CC. For instance, the WooCommerce plugins at WooThemes. You can’t expect everything to be on Envato Market. And to make the potential buyers aware of an external dependency’s source is really an obligation. As long as it’s just a small mention in form of a link, rather than prominently advertising the dependency, it should be allowed.
The reasoning is quite simple. It’s in-line with the WordPress philosophies of separating what belongs to plugin territory. It’s also what a lot of authors want here with all the hue and cry over “mega themes”.
Efforts like these are exactly what we need if we are to get away from encouraging bundling “100 themes+plugins in one”. It’s only in the best interests of authors – and even buyers when the external plugins are much higher quality and supported by the plugin author.
- wp_kses has a performance impact.
It’s a common micro-optimization misconception spread by the purists who would be disgusted to see usage of double quotes vs single quotes. The reality is it depends on your content length. Relevant post: http://themeforest.net/forums/thread/what-to-use-instead-of-wp_kses/165526?page=1&message_id=1225350#1225350
It depends on where you’re using it. You have to think about the use-case, however. If you’re using it on large content, sure it will not have good enough performance.
But if you are going to use it on small chunks of text spanning to a few lines at max, then it’s perfectly acceptable to use it when you have to preserve some HTML tags. The performance impact of such usage is negligible. You’re better off optimizing your querying in such a case.
A good read reviewer might be interested in: https://www.tollmanz.com/wp-kses-performance/
To re-iterate, you can use wp_kses* functions even on the front-end functionality, as long as you don’t over-do it.
The alternative is the violate the suggestion of “always escape late”, and sanitize using wp_kses pre-save via hooks. Personally, I am not a fan of this method and the reviewers will get further confused when you sanitize early. It’s also easy to miss escaping/sanitization when you’re sanitizing early.
The current method employed by Envato to collect feedback on pressing matters is lackluster. A better process would be to conduct long-term surveys. While your previous effort to conduct surveys was a fine attempt, the sample size was too low for a market of this size. If you need help, you can always ask us authors to encourage our buyers to provide feedback.
It will be hazardous to misconstrue opinions of the vocal minority as representative of the whole. While in theory it can be argued that the same group will be answering the surveys, given the right strategy and time, the data collected can be representative.
Good first step in moving away from terrible readability of old item pages but it’s neither polished, nor complete at this point. And it would have been better if these changes were detailed before being implemented (more than just a sneak peak).
15px font with 1.6 line-height (24px) would have been much better. As others have pointed out, it does look out of proportions with rest of the design elements at the moment.
Also it seems like paragraph margins weren’t adjusted and are still at 20px.
A condition like this will work:
if (function_exists('is_shop') && is_shop()). If the first part of the logic fails, the second part is never reached when using logical AND operator.
At the moment, the trick is to have few very distinctive elements to set themes apart from others. Typography, visual hierarchy, spacing, and the general template dogma usually isn’t the reason. A lot of subjectivity comes into play as well.
If you happen to be in the industry for long enough and understand the terms, you can observe what’s being accepted. You will definitely notice violations of aforementioned points, yet they may have a few unique elements or newer trends.
Sadly, quite a few of the rejected themes adapt to please the reviewers rather than the true objective – pleasing the user and selling. Reviewers might push for newer trends that, depending on theme category, haven’t caught on yet A better approach is to create a unique blend to meet both expectations.