@TechBridgeWeb: Thanks for your suggestion!
@dnp_theme: Haha. Yes, you just did a review! Thanks!
You guys are right, I should have carefully checked the typography when designing.
@icypixels: Thanks so much for your constructive feedback! I will further work out on the typography and other points you suggested. And try to fine tune other details that could affect the result. As you know, sometimes, finding mistakes in our own design is quite challenging.
Your comment really boosted up my energy, thanks again!
Amazing update, love it! Thanks Justin!
I see. Thanks @CRIK0VA, @kiratheme.
What features would you suggest for the simple blog theme?
Note that I decided to remove the “sidebar” stuff out of the design intentionally (having only the footer widget area). Not sure whether the sidebar is considered/needed or not. :-/
Sadly, I just got hard rejection email this morning for the theme: [EDIT: Link removed]
Could you guys help me for more insight in which points I am missing?
Or, is it too simple? Does it really not have a potential?
Actually my intention is to make the theme as a simple blog with clean design.
Thanks for all your help.
@UXbarn: surely, you must use esc_html instead. I fall asleep
Hmm. I don’t think this is what I can use because I need to print out that HTML to be rendered on screen. If I use “esc_html()” for the ”$output” variable, I will get the plain string on screen (escaped HTML).
Are there any reviewers or staff can give a clear answer about this? What method do I need to use to validate the final echo here? Or, in other words, what method to validate the entire “HTML output” when echoing it?
@kotofey: Thanks! I will try that. But for the HTML output, I am not sure whether it is okay to use “esc_attr()” in this case? Will this give the expected result?
@billyf: Actually, my HTML output is dynamically created with conditions in PHP code so that’s why I use variable to store and deal with that before final printing out (or returning it from the function). I think it would be easier to handle and manage the code.
I am interested to know like you too about what is the method to validate the content with HTML tags. Just no idea what to use and how in my case. :-/
I have seen many threads talking about soft rejection with the reason of output validation. In short, the reviewer asks us to check every “echo” to validate the output and they will check for every “echo” to ensure that.
But I still have a question on this. What if I write the code like this:
$text = ot_get_option( 'text_option' ); // From Theme Options $class = ot_get_option( 'class_option' ); // From Theme Options $output = '<span class="' . esc_attr( $class ) . '">' . $text . '</span>'; echo $output;
As you can see that the HTML class is actually validated/escaped in the ”$output” variable. And the ”$output” is just printed out on screen.
So I am wondering that what validation method must I use for the final “echo” of the ”$output” variable?