Posts by WordPress_Coding_Standards

no-thumbnail
WordPress_Coding_Standards Recent Posts Threads Started
7 posts
  • Has been a member for 1-2 years
WordPress_Coding_Standards says

Just when you thought you’ve thought you heard it all. Maybe he is still deciding on what theme he bought. Sir can you please describe the stolen item? Can you identify the developer in a line up?

no-thumbnail
WordPress_Coding_Standards Recent Posts Threads Started
7 posts
  • Has been a member for 1-2 years
WordPress_Coding_Standards says


Why is not a requirement to use the bundled version of jQuery and enqueue it using the proper API ?

Why? Because WordPress is always eons behind latest release version of jQuery (and other js libs as well).

Right now, bundled version is 1.7.2, last one on Google CDN is 1.8. I want to use latest and fastest one, period.

If you followed WordPress development you would know that the latest stable jQuery release 1.8.0 is already in trunk along with jQuery UI 1 .8.23. You can’t just drop in the bleeding edge version of jQuery and expect everything to work. It needs to be tested to ensure there are no compatibility issues like the fact that using jQuery 1.8.0 breaks all drag and drop meta boxes in admin unless jQuery UI is also updated to the latest version. And another point is when you release your theme today with what ever version you specify 2 years from now it will be outdated. I see themeforest themes all the time that shipped with older versions that are no longer compatible.

I just looked at one of your themes and it is being sold on here today and it is using jQuery 1.5.1. Sure it works in the preview but what happens when one of your users installs a plugin?

http://themeforest.net/item/camelus-nature-tones-business-template-/full_screen_preview/76549
no-thumbnail
WordPress_Coding_Standards Recent Posts Threads Started
7 posts
  • Has been a member for 1-2 years
WordPress_Coding_Standards says

Well I want to take back the remarks I made about enforcement of coding standards. After going through these forums it is obvious that Envato is now enforcing coding standards. I think this is a step in the right direction and will improve the overall quality of the products being sold here. If any theme authors need help bringing their themes up to any of these standards please contact me. I will be glad to help in anyway I can.

no-thumbnail
WordPress_Coding_Standards Recent Posts Threads Started
7 posts
  • Has been a member for 1-2 years
WordPress_Coding_Standards says
well, pissing off a whole community in one thread is really an achievement there should be a badge for that. it was a fun read

Yes it is an achievement. It’s an achievement that you will ultimately benefit from because raising the standards of this market place has to be done to keep this marketplace going.

The remarks and attitude toward CiprianTurcu are really showing why there are so many problems with the themes here. Most of the successful authors already follow these standards. Hopefully the requirements will weed out the developers who only care how quickly they can churn out the same crap over and over again just to make a quick buck. Users think all the themes on here are great because they look so pretty in the demos but when they get them home and try to make them actually work they get frustrated and take it out on WordPress not realizing they paid for something that doesn’t actually work or were mislead by the marketing and features and options stuffing going on here.

I help users everyday on wordpress.org with your themes and they paid you. Why because I actually care about WordPress and making users happy.

Thank you CiprianTurcu for your efforts in improving quality. It seems like these standards are finally getting enforced.

no-thumbnail
WordPress_Coding_Standards Recent Posts Threads Started
7 posts
  • Has been a member for 1-2 years
WordPress_Coding_Standards says

It’s mandatory because it is the right way to do it. Your users deserve to be able to use WordPress nav menus.

What if your user decides he wants to create an extra menu item related to a category then add a child category as a drop down. Your way restricts this.

Themes should not limit the use of any WordPress features. Kudos to Envato for finally enforcing standards.

no-thumbnail
WordPress_Coding_Standards Recent Posts Threads Started
7 posts
  • Has been a member for 1-2 years
WordPress_Coding_Standards says

This is so great that Themeforest is finally enforcing this. Thank you Envato!!!!

The theme authors need to read up on the codex. You don’t enqueue scripts in the header. You enqueue them via a call back function that you attach to the wp_enqueue_scripts hook.


function my_prefix_load_js() {
     wp_enqueue_script( 'pretty-photo', get_template_dir().'/js/pretty-photo.min.js', array( 'jquery' ), false);
}

add_action( 'wp_enqueue_scripts', 'my_prefix_load_js' )

This is how dependencies work and why so many themes on here break when plugins use proper dependencies. the array( ‘jquery’ ) tells WordPress that your script relies on jquery to work so it will then make sure jquery is loaded before your script. You don’t need to enqueue it because you defined it as a dependency.

In the past when you put all your registers script calls in header.php its too late and will cause two versions of jquery to get loaded which why so many plugins break.

AGain kudos to Envato for stepping up and enforcing The WordPress APIs!

no-thumbnail
WordPress_Coding_Standards Recent Posts Threads Started
7 posts
  • Has been a member for 1-2 years
WordPress_Coding_Standards says
On the other hand, it is also sometimes very hard to have files approved. Some of the top authors here get declined every day. This is also the reason why the files on the site are top shelf quality.

Top shelf quality??? This is simply not true. There are some “top shelf quality” products here but the majority of themes cause so many problems and waste so much time for support people who actually solve problems.

Can somebody please point me to this list of requirements. This should be transparent to your users so they know what they are paying for. If Themeforest wants to make things better for WordPress they need to start enforcing the same quality guideline that are used for the FREE themes on WordPress.org

If these requirements iare so strict why are themes being sold here everyday that are so poorly coded they break plugins and generate PHP warnings and notices on every page load. Why is not a requirement to use the bundled version of jQuery and enqueue it using the proper API ? Why is not a requirement for themes to not generate php notices and errors. Why are the theme authors allowed to copy and paste javascript powered options pages that are confusing and bloated? Why do almost 90% of the themes on here use the same three jQuery plugins, Nivo Slider, Pretty Photo and hover intent? Is that a requirement? Colis publicly stated over a year ago that this would get cleaned up but nothing is being done.

There are some top notch industry leading designers on here but only a handful of developers. If the theme is flashy and has lots of bells and whistles it makes money. That is the requirement.

by
by
by
by
by
by