Thats what I thought. Thanks anyway. I now implemented it like this, if anybody runs in the same problem:Nice approach. Thanks!$embed = new WP_Embed(); $video = $embed->run_shortcode('[embed height="200"]'.$your_video_url.'[/embed]'); $video = preg_replace('/width=\"(\d)*\"/', 'width="344"', $video);Its not a solution I am proud of, but it works and doesn’t destroy my styling anymore
I am trying to get the embed function of wordpress to resize embedded flash images to a given height and(!) width. Right now, the method seems to resize videos only proportional, as they get the information via oEmbed. Is there any flag that I have overseen, or should I directly manipulate the output given by
$foo->run_shortcode()with regex or whatsoever?
In short: I want a video to be rendered in a given box, lets say with a size of 200×120. The embed class only returns videos in the proportions they were recorded at. 16:9 or 4:3 or …
Any Ideas?Cheers Bebel
Afraid not, its not wordpress thats the problem, its the oembed protocol. The source (for example youtube) must respect width, but they don’t have to respect height.
I get that. But really, how hard is it to say “your typography sucks”, or ” its just not original enough” or even” its good, but doesn’t fit our style”.Hey ashgoodman if you replied the email the reviewer will get in touch with you very soon.
Thanks! I have already started modifying the typography so if he is going to look at the live demo again to give feedback the live demo it’s in mid tweak (especially the sidebar typography) . I look forward to hearing him although I think I actually replied to Drew as I never actually received the email from the reviewer, only Drew’s forwarded copy of it (and it’s not in my Spam box either)
Well, here’s the thing: The reviewers aren’t here to tell you what to fix. They are not supposed to be teaching us how to make a better design. Their job is to either accept a submission or to decline it. BUT … because the reviewers rock so much, they will provide more details if you ask them. Not because they have to but because they’re nice enough to do it.
I get that. But really, how hard is it to say “your typography sucks”, or ” its just not original enough” or even” its good, but doesn’t fit our style”.
Like I said I am not even looking for specifics, just a nod in the right direction. I do this for a living so I can’t be that far off the mark. Or if it is I would like to know. That way I could bin this one and start on another another, I have been gearing up for this for a while and have loads of designs ready to be made into themes.
Anyway, no need to beat a dead horse. I don’t expect policy changes I just wish I didn’t have to tackle this blindly.
I do appreciate the offers from all of you to review it, but as I said, its the reviewer I need to please at this stage and no matter what you guys tell me about what you think of my theme its still not going to tell me what he /she thinks.
I’ll be resubmitting soon (is there a time period you have to wait between resubmissions?)
Been tweaking my typography some, and had an idea for extending one of the features that I didn’t include as I wanted to get it ‘done’ – now I have an excuse to go ahead and add it in.
Just chill out for a second and take a step back. Your all mad that your theme has gotten rejected….but many many many themes get rejected on a daily basis (including themes from some of the better authors here). My last theme was rejected 7 times .
The point is, you are a seller wanting to sell through another company. Don’t get angry and don’t get discouraged….take a day off to recoup and then hit it again.
You can also post your theme up on ConceptFeedback and see what reviewers think.You can also head over to WeLoveWP to receive inspiration.
Actually I am not mad it has been rejected. In fact I have stated a few times now that I don’t mind the rejection, and in fact welcome constructive criticism.
What I am bothered by (not mad, bothered, disappointed even) is the fact that there was no criticism constructive or otherwise. Just a form email that says “due to our current quality standards, your template has been declined” and
“Your template’s design does not meet our quality standards at this time and will need significant improvements before it will be ready to be reviewed again”
“At this stage in the design I am, unfortunately, not able to provide more specific feedback other than what I’ve stated above (the design needs overall, general improvements). With further improvements I may be able to provide more specific feedback.”
Which basically says nothing at all other than, make some changes (but I can’t say what changes you should make) and then resubmit, then – maybe, just maybe… I’ll tell you what’s wrong.
My whole point here is that I know my theme isn’t that bad, for crying out loud I do this for a living (and quite a good one at that)! I am all for improving things, but tell me what needs improving. I want this from the reviewer because, after all, he is the one who I have to please here.
I am not even asking for specifics. Just tell me what ballpark it is… Is it the typography? The overall design? The style?
Or my choice of images for the demo content (thats what my wife thinks it is… which , if she is right, is pretty sad as the images don’t come with the theme)
So no, I am not mad. I am frustrated that after weeks of working and investing in this the best I can get is a form letter for a response.
I actually figured going in I would get rejected the first time, that’s how you learn. And that, in a word, is my whole point. LEARN .
You can’t learn a thing unless there is communication. I am not about to go around making changes blindly… for all I know I could change the things the reviewer did like and make things worse! I expected I would be told you have been rejected because… instead I got a form letter that repeated itself a few times, said nothing very material and provided absolutely no relevant guidance.
The closest thing to guidance it provided was to tell e to look at other themes on the site (did that before I started, and do it everyday) and read the guidelines (referenced them dozens of times while developing and preparing for the upload).
So instead of straight answers I am given a mystery.
Wanna show your theme? Sometimes it helps to get suggestions from other designers and coders, especially if you have no idea on what to improve. Greetings, GC
Yes, after I hear from the reviewer first. I want to know what the yardstick is. If it involves my theme becoming just another clone…
I have loads of people lined up to buy the theme already (...)Believe me, if you make it better and it gets approved, you’ll get 10 x more people lined up to buy it.
Absolutely, that’s why I was interested in selling it here.
To be honest though I don’t see how it could have been properly reviewed. 1 minute I was 10 of 12, the next I was hard rejected. That’s hardly a comprehensive review process…
It would be nice if your reviewer could be more specific.If you reply to your rejection email asking for more details, your reviewer will provide it. And don’t get discouraged… when you get the recommendations by your reviewer, think about it objectively and improve upon your design. And of course, you can always post a preview link on the forum to get constructive feedback from us too.
I have done so, I am happy to receive constructive criticism, my issue is the fact that I got none. Hopefully the reviewer will reply with something constructive I can take and work with to improve things
“I have loads of people lined up to buy the theme” I heard this sentence so many time when people posted about their rejectionThanks for the assist
The item has been reviewed and a message sent to you about 30 mins ago. In case you didn’t receive it, I sent you a support ticket with the reviewers message regarding the item.-Drew
Hi Drew, Thanks for your reply. Unfortunately there was nothing in the email helpful at all. I have loads of people lined up to buy the theme already but apparently its “not up to your quality standards”.
It would be nice if your reviewer could be more specific.