Posts by mimo

33 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
+2 more
mimo says

I, i have a simple question, hope someone, stuff or author can help me with this:

Do i have to validate all language strings like this?

_e(‘my text’,’mytheme’);

To this?

esc_html_e(‘my text’,’mytheme’);

?? Can someone point me in the right direction?

Thank you very much

33 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
+2 more
mimo says

Hi, just visit

http://support.envato.com/index.php?/Knowledgebase/Article/View/472/85/wordpress-theme-submission-requirements

And be sure your theme meets all the requirements

Best Regards

33 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
+2 more
mimo says

I can’t see how this is a fix. You are just removing it, not fixing it. I don’t see the good news here.

Hey Scott :)

Just found this thread, not sure if it’s been mentioned, but an ability to update the package or item page description whilst the item is in the review queue would be amazing, though this is probably beyond the scope of what this update was for.

Totally agree.

33 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
+2 more
mimo says

I have to agree, this looks extremely spammy and amateurish.

+100

33 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
+2 more
mimo says

Thank you EugeneO. I have seen for example infinitescroll plugin js do this ,

(function($) { “use strict”;

//Plugin functions })(jQuery);

So for this reason i thought that was the correct way to do things.

Best Regards

33 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
+2 more
mimo says

Well i love to hear this, then all my functions are ok, and my site works great. I was trying to make things work in that way with no luck.

As tommus has flagged this to get a staff reply, let’s wait to see what they say about this.

Best Regards

33 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
+2 more
mimo says

Hi, thank you OriginalEXE for the answers, but what we were talking about was just that.

Look at the fiddle Tommus has linked, it is exactly the same example as yours but i think this cannot be done know because of the New Theme Requirements say that all js from Author must be enclosed in a function scope like:

(function($) { “use strict”;

//Author Code

})(jQuery);

I think just to prevent issues with other libraries and plugins. Or, are we missing something??

:):) Thank you

33 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
+2 more
mimo says

Why don’t you try to use “use strict”; for the whole document instead putting it inside of every function? line 1: “use strict”; line 2: your code…

That was the first thing i did, then all the functions get undefined

Regards

33 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
+2 more
mimo says

Thank you. Just to clarify i would ask some questions:

All js means all js when enclosing it in (function($) { “use strict”;

//Author Code

})(jQuery);

???

so i need to do:

(function($) { “use strict”;

//Author Code With my function

})(jQuery);

In other file when needed for example:

(function($) { “use strict”; $(document).ready(function(){ //Call my function }); })(jQuery);

Is this the needed structure?

I am only asking because i just have tried to make this work for hours, well, you know, change this, look google, change that, look google, change the other and no luck at all. Have read all the poor documentation available about “use strict”; and i am a bit confused.

Have inspected some very well known scripts written in that way, working perfectly, so i may be missing something important to make mines work in this way.

So the important question for me is how i have to rewrite my functions written in the mode TommusRhodus has linked in fiiddle, to work in this way???

:) Thank you very much

33 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
+2 more
mimo says

Hi, yes, of course this works, but as it said in theme requirements all js must be inside (function($) { “use strict”;

//Author Code

})(jQuery);

The fiddle you have linked works because the only difference is the “use strict”; at the begining, but the code is not enclosed in the (jQuery) function as needed.

Or i am losing something with Theme Requirements?

by
by
by
by
by
by