Posts by rayoflightt

no

I added js to the bottom of pages and CDATA encoded js and finally template has been approved! Thank you all for advice. Fortunately I didn’t have to validate all jquery.js.

designedbydash said
Throw the JS to the bottom of the page and don’t worry too much about the JSHint, typically if you move the JS to the bottom that satisfies that criteria. We got soft rejected with that notice and merely moved the JS and we got approved

I’ll try that, thanks.

wickedpixel said
The js in the footer rule seems a pretty radical move. Or full jsHint compliant. Probably you had really bad code and they enforced you to use this rules in order to make you repair stuff. Hm.

Actually that are common scripts -jquery.js, camera.js, flex.js etc. I don’t have my js code written. And as I said all scripts were used before. So how could I validate all jquery.js library? That is crazy.

purethemes, thanks I’ll try that. But it seems this is a new TF requirement.

I just got my template soft rejected with following explanation:

“JavaScript files need to be placed at the bottom, barring critical exclusion. [Modernizr, for instance] JavaScript loaded directly into HTML documents (template files) should be CDATA encoded to prevent errors in older browsers. The javascript should be JSHint compliant. Make sure the CSS file is well documented with proper table of content.”

I use the same scripts as I used for my previous templates and never got this kind of requirement. Actually I don’t understand what should I do with scripts. “CDATA encoded and JSHint compliant. What is that supposed to mean? I make template for ie8 and above.

Did someone got the same requirement and can give me an advice? Thanks.

sevenspark said
You can argue whether Bootstrap is good or bad, but the reason it’s popular is that it’s useful, plain and simple

Agree. I use it and like it but I would never use it’s buttons and tab styling etc. just grid, responsive feature and some of js. I used Foundation too but it requires more work with adding classes for mobile, Bootstrap needs only one class and it is responsive already. I don’t have experience with other frameworks and also why bother with less known frameworks when mainstream sells.

themebros said
Depending on how fast you learn you will need 3 to 5 years to learn all that and have enough experience to build HTML templates and WordPress themes that you can then sell.

It can be faster. For example I started to learn html about one year ago and got first template approved about 8 months after that. Recently I started to learn php and make Wordpress framework and hope will know enough to be able to convert html to Wordpress for 6 months from now, if I have enough time to learn.

English is important for learning, because all good and fresh tutorials are in English.

I got this: “Additionally, we have some extra feedback for you:

please provide details item description. After editing, click save, resubmit.

This Ecwid template should look like its a natural part of the site/template

This Ecwid template must have custom images.

Please resubmit to Site Template category.”

What are custom images in ECWID template?

Only custom ecwid images that I noticed are vegetables when editing ecwid widget. Should I left it in my preview?

Check and remove media queries from all css files if there are separated files for slider etc. Also try to put all layout into div with 1024px fixed width.