I’m going to ask again @envato. What is the final world for:
- how about widgets? - how about css frameworks that have some buttons styles like foundation/bootstrap? - why is so hard to create a FAQ and give us some light?
It’s time to update your guidelines. A lot of answers were given on this thread. Do you want us to go over all these pages to figure out what can we and what we cannot do? For example: how about theme specific widget? Can we put within theme? I almost sure you already answered that question, but i don’t have time to go over 39 pages. So, it’s time to clean up this mess.
I believe that when things like this occurs, the proper/best way is to first contact the author before disabling an item that was approved ( and has a lot of updates approved ). As you know, we are humans and we can interact with each other in order to minimize the impact on both sales and frustration level.
@Envato team : Instead of moving all functionality to a plugin, can’t we still keep the CPT ( for example ) in the theme and just add an extra plugin in the theme package that will contain just the functionality of the CPT ?
How i see the things :
1. The user installs the theme 2. The user can benefit from all the theme features ( portfolio, shortcodes , etc) 3. The user want to switch to a different theme and disables the first theme ( at this stage, he will lose all the theme features – CPT , shortcodes, etc ) 4. The user ( if he still want to use the first theme’s features ) installs the plugin provided in the theme package and he will get the CPT and shortcodes functionality
By doing this, the clients and developers are happy ( in my opinion )
my 2 centsBest regards, Stefan
That’s not simple. Plugins developed to a specific theme will carry the theme’s style. It will not be a plug and play thing for other themes. For example: future plugins from Kallyas will not be useful for people that have Avada theme. Completely different styles. In the end, Envato will ‘force’ the user to code and tweak plugins.
Like @duotive said, i think Envato is confusing wp.org with premium themes.
I quite agree with Submission Requirements Phase One, but phase two is blurry.
^ well the point of having CPTs inside a plugin is that user can access the data when he/she changes theme.
Yes and no. You still can have your CPTs inside a plugin and make them tied to your theme. Just because your CPT is a plugin, it doesn’t mean that it will work plug and play on other themes. If the intention in having CPT in plugins is to ‘protect the buyers’; Envato will really need to review all themes and make sure that the authors don’t tie the CPTs to their theme in someway.
I’m personally really happy with these guidelines, maybe because my most recent themes already comply with them!
However, I strongly disagree with the
What older browsers? Browsers others than the ones officially supported by the Theme?
CDATAmarkers will prevent ”<” and “&” to be treated as the start of markup by the XML processor.
The above is true for XML document (including XHTML), but not for HTML documents (including HTML5). Therefore, whether we should use
For any HTML documents, not only CDATA is useless, but it is cumbersome as it requires to be commented out as they are not valid HTML syntax (i.e.
//--><!]]>...), while for XHTML or any other XML document (like SVG or MathML) the simpler basic syntax is to be used (i.e.
I believe that the “errors in older browsers” mentioned in the Submission Requirements, refers in fact to the errors caused by the use of
CDATAwrapper itself in HTML documents (which should not be used in such documents)! Those errors are solved by commenting out the
CDATAwrapper with an appropriate syntax – or should I say a “complex” commenting syntax – and the older the browser you want to fix this misuse for, the more complex the syntax gets (see Joel Purra’s answer on this).
Requiring to add
CDATAmarkers in all cases for all Themes is irrelevant and totally cumbersome. The reason why WordPress adds
CDATAmarker is not compatible with).
I believe you should definitely review this requirement for better code quality. You could simply rewrite it like so:I sincerely hope that my thoughts clear things up a little so the Submission Requirements can be improved in order to avoid useless degradation of the global code quality on ThemeForest Best, Jonathan
CDATAmarkers if the Theme uses an
CDATAmarkers if the Theme uses an
CDATAwrappers, if used, should be commented if the Theme uses mixed
CDATAwrappers, if used, should be escaped using special syntax if the Theme uses mixed
HTMLDoctypes, and if the Theme supports pre-IE6 browsers, “to prevent errors in older browsers“
Jonathan is right. The CDATA requirement must be reviewed.