366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

Buttons, dropcaps, lists shortcodes should be inadmissible shortcodes to follow this suggestion http://justintadlock.com/archives/2011/05/02/dealing-with-shortcode-madness from JustinTadlock.

I’ll discuss this further with the review team. Thanks for the link!

279 posts
  • Sold between 50 000 and 100 000 dollars
  • Exclusive Author
  • Has been a member for 1-2 years
  • Bought between 10 and 49 items
  • Referred between 10 and 49 users
PrimaThemes says


Could you please re-check again about admissible and inadmissible shortcodes?

I see buttons, dropcaps, and lists are admissible shortcodes, but columns, maps, and contact forms are inadmissible shortcodes….

Switched? Are you sure?
Sorry, I’m not exactly sure what you’re asking..

Japh, please read this article from JustinTadlock http://justintadlock.com/archives/2011/05/02/dealing-with-shortcode-madness I think it is better if you put buttons, dropcaps, and lists shortcodes to inadmissible lists…

114 posts
  • Elite Author
  • Sold between 100 000 and 250 000 dollars
  • Exclusive Author
  • Bought between 100 and 499 items
  • Referred between 50 and 99 users
  • Most Wanted Bounty Winner
  • Envato Studio (Microlancer) Beta Tester
  • Has been a member for 2-3 years
nagaemas says

Hi,

Thanks for the update, I’ve been working on my first WP theme and framework for the past two months. I was worried after seeing many talks about how WP themes should only handle presentation, not functionality. This post makes me sure that I’ve to move all the functionality of my themes into a plugin and activate it with TGM Activation.

This all means that when we create themes, we don’t include our WP framework into the theme, but instead ship a set of our custom plugins that handles the functionality, while passing the rendering of HTML and CSS to the theme right?

The question is, is it allowed to make my own core functionality plugin (like this one here: http://www.billerickson.net/core-functionality-plugin/), that accepts my other set of plugins as its components. The components then, will not work without firstly installing the core plugin as they depends on hooks of the core plugin.

Thanks!

114 posts
  • Elite Author
  • Sold between 100 000 and 250 000 dollars
  • Exclusive Author
  • Bought between 100 and 499 items
  • Referred between 50 and 99 users
  • Most Wanted Bounty Winner
  • Envato Studio (Microlancer) Beta Tester
  • Has been a member for 2-3 years
nagaemas says

One more question, so theme options framework like NHP or SMOF is no longer allowed as they are not plugins but more of a framework we need to include?

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

The question is, is it allowed to make my own core functionality plugin (like this one here: http://www.billerickson.net/core-functionality-plugin/), that accepts my other set of plugins as its components. The components then, will not work without firstly installing the core plugin as they depends on hooks of the core plugin.

There’s no problem using a core plugin that can be extended by other plugins. Many other plugins do this.


One more question, so theme options framework like NHP or SMOF is no longer allowed as they are not plugins but more of a framework we need to include?

I don’t see any reason why you couldn’t use a theme options framework, providing your theme still passes the requirements :)

10 posts
  • Exclusive Author
  • Has been a member for 1-2 years
deeppurple says

Hi,

I’m using reCAPTCHA library in a theme which uses base64_encode, fwrite, fsockopen and fclose. Is it allowed to use it reCAPTCHA library?

In my opinion, it is not possible and it should not be required to eliminate the info messages.

You will get INFO messages for the following cases:

1. If you place link to your website in theme options or anywhere in the backend so that user knows where to get support.

2. If you use ANY iframe. ALL social buttons, videos and other embedded media uses the iFrames.

Even the wordpress.org official theme directory does not require to eliminate the INFO messages.

114 posts
  • Elite Author
  • Sold between 100 000 and 250 000 dollars
  • Exclusive Author
  • Bought between 100 and 499 items
  • Referred between 50 and 99 users
  • Most Wanted Bounty Winner
  • Envato Studio (Microlancer) Beta Tester
  • Has been a member for 2-3 years
nagaemas says


The question is, is it allowed to make my own core functionality plugin (like this one here: http://www.billerickson.net/core-functionality-plugin/), that accepts my other set of plugins as its components. The components then, will not work without firstly installing the core plugin as they depends on hooks of the core plugin.

There’s no problem using a core plugin that can be extended by other plugins. Many other plugins do this.


One more question, so theme options framework like NHP or SMOF is no longer allowed as they are not plugins but more of a framework we need to include?
I don’t see any reason why you couldn’t use a theme options framework, providing your theme still passes the requirements :)

Thanks for the answer :)

One more thing, WP Core API #12:

The text domain parameter must be a string and not a variable or constant.

Is this for the text string or the text domain parameter? As theme-check doesn’t throw any errors if only the text_domain that is using a constant/variable.

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

I’m using reCAPTCHA library in a theme which uses base64_encode, fwrite, fsockopen and fclose. Is it allowed to use it reCAPTCHA library?

In my opinion, it is not possible and it should not be required to eliminate the info messages.

You will get INFO messages for the following cases:

1. If you place link to your website in theme options or anywhere in the backend so that user knows where to get support.

2. If you use ANY iframe. ALL social buttons, videos and other embedded media uses the iFrames.

Even the wordpress.org official theme directory does not require to eliminate the INFO messages.

We want you to eliminate them as much as possible, and anything remaining, will be left to the reviewer’s discretion. But you’ll know that if they are left over, there’s a chance it’ll be a problem for approval.


One more thing, WP Core API #12:

The text domain parameter must be a string and not a variable or constant.

Is this for the text string or the text domain parameter? As theme-check doesn’t throw any errors if only the text_domain that is using a constant/variable.

This is for specifying the text domain parameter.

1719 posts Don't Worry, Be Happy
  • Beta Tester
  • Grew a moustache for the Envato Movember competition
  • Elite Author
  • United States
  • Sold between 250 000 and 1 000 000 dollars
  • Has been a member for 3-4 years
  • Referred between 200 and 499 users
  • Most Wanted Bounty Winner
+2 more
FinalDestiny says

So from now on all the multipurposes will be kind-of-dead? Or they’ll bundle 50 plugins that will anyway NOT LOOK & WORK properly when you switch themes because each theme has individual styling.

From my point of view, we should be selling a complete website solution, not just a part of it. We’re not selling themes to people that change themes like their socks, like they do on wordpress.com or the ones that expect the same look and functionality when they change a premium ThemeForest theme with one from WordPress.org.

3434 posts Ruben Bristian
  • Most Wanted Bounty Winner
  • Elite Author
  • Sold between 250 000 and 1 000 000 dollars
  • Has been a member for 6-7 years
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
  • Won a Competition
  • Bought between 100 and 499 items
  • Exclusive Author
  • Referred between 500 and 999 users
+5 more
KrownThemes says

What about Option Tree? It throws errors in the theme check..

by
by
by
by
by
by