736 posts
  • Has referred 500+ members
  • Has sold $125,000+ on Envato Market
  • Has collected 50+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+7 more
mordauk says

Also “The text domain parameter must be a string and not a variable or constant.” this is semi silly, there some cases where classes use a constant(filtered) to define the parameter so it can be reused. also there are a few theme frameworks that use a constant.

No, actually is must be a string. Setting it to a constant makes it not actually work.

611 posts
  • Member of the Envato Team
  • Had an item featured in an Envato Bundle
  • Made it to the Authors' Hall of Fame
  • Contributed a blog post
+10 more
Siddharth Envato team says

One thing I have to mention, again, is that for something so important to the core of this site, it’s products, and thousands of peoples sole way of earning a living, you did another awesome job of placing this on a blog (notes) that no one reads, started a forum thread on the 4th of July (the biggest holiday in the US and many have taken a few days off and may miss this), and didn’t put a message on authors dashboard, nothing in the notices section of my dashboard and no banner at the top to inform us.

I admit, that’s a gaffe on our part. None of the people involved are based in the US and overlooked this.

I’ll definitely see if I can push this message onto authors’ dashboards.



Also one note about the W3c validation, what about prefixes or things that are included with the current spec but support across major browsers? W3c should be used a guide but almost no modern site really validate because of prefixing
This is 100% correct imo. Show me a modern, good looking usable website that is fully validated. I really don’t know of any. Best to make sure that there’s no huge mistakes and if the theme works on all browsers it states without any errors then that’s proper validation.

Browser prefixes and any other cutting edge code can and will be added to the exemption list. We encourage authors to push the boundaries of their themes and as long as it is performant and degrades gracefully, I’m sure it will be just fine.

I just want to reiterate that some of the rules aren’t set in stone. In issues like JSHint compatibility or validation, in this case, the review team can assess the situation on a case by case basis.

3427 posts
  • Has sold $5,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Located in United States
  • Has been part of the Envato Community for over 4 years
+1 more
organicbee says


Also “The text domain parameter must be a string and not a variable or constant.” this is semi silly, there some cases where classes use a constant(filtered) to define the parameter so it can be reused. also there are a few theme frameworks that use a constant.
No, actually is must be a string. Setting it to a constant makes it not actually work.

hmm its working fine for me

736 posts
  • Has referred 500+ members
  • Has sold $125,000+ on Envato Market
  • Has collected 50+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+7 more
mordauk says



Also “The text domain parameter must be a string and not a variable or constant.” this is semi silly, there some cases where classes use a constant(filtered) to define the parameter so it can be reused. also there are a few theme frameworks that use a constant.
No, actually is must be a string. Setting it to a constant makes it not actually work.
hmm its working fine for me

I’ll let Otto explain it: http://ottopress.com/2012/internationalization-youre-probably-doing-it-wrong/

92 posts Be different!
  • Has referred 500+ members
  • Has sold $1M+ on Envato Market and is now a Power Elite Author
  • Has collected 10+ items on Envato Market
  • Power Elite Author: Sold more than $1M on Envato Market
+3 more
UnitedThemes says



Also “The text domain parameter must be a string and not a variable or constant.” this is semi silly, there some cases where classes use a constant(filtered) to define the parameter so it can be reused. also there are a few theme frameworks that use a constant.
No, actually is must be a string. Setting it to a constant makes it not actually work.
hmm its working fine for me

Yes its working for manual translations bot not for automated, here is an article about it: link

But to be honest, we also didn’t know about it and used constants.

92 posts Be different!
  • Has referred 500+ members
  • Has sold $1M+ on Envato Market and is now a Power Elite Author
  • Has collected 10+ items on Envato Market
  • Power Elite Author: Sold more than $1M on Envato Market
+3 more
UnitedThemes says

Also if this post here goes a bit out of the scope, but the TGM Plugin Notification combined with this library here works like a charm ! So if someone is a bit scared on how to update non wordpress repository plugins, here you go : plugin-update-checker

631 posts
  • Has referred more than 5000 members
  • Has sold $2M+ on Envato Market
  • Has collected 100+ items on Envato Market
  • Had an item featured in a magazine
+9 more
Kriesi says

Try and tell me that building and maintaining your own contact form (just as an example) that is implemented separately in every theme you build is easier to update than supporting a plugin via just a few lines of CSS.
Hey Pippin!

Thats the point: I dont go for easy. I go for great user experience. And implementing 4-7 different plugins to get all the features I need is a crapy user experience if you ask me. And not because installing them is hard (but certainly not great either if you activate a theme and need to install several plugins before you can even think of starting to use it).

Its because each and every plugin comes with
  • Different layout, style and branding
  • Different Workflow
  • Different (often strange) location to access
  • Different Update cycles

If you use 5 plugins it might be great for you as a developer (no initial developing time, no need to write new features yourself, etc) but it wont be great for your customers. Which ultimately might backfire anyways since you probably have to deal with a lot more requests on how to install feature X or how to setup feature Y.

I agree with you: in an ideal world where developers don’t overbrand their plugins and use WordPress Styling and where customers have at least read a basic “How to use wordpress” article the pure plugin approach might be far superior to what we do now :)

But as long as I have customers who have never used anything else other than twentyeleven and plugin developers who try to cross sell the shit out of their customers from the wordpress backends I will keep coding as much as possible by myself.

What I agree to: if you make the effort to code something yourself into the theme, at least make sure that it would work as a plugin too. I have spent almost 2 months to create my own template builder instead of licensing one but I made sure that it is built in a way that I can also offer it as a plugin to people who really want to switch themes :)

64 posts
  • Sells items exclusively on Envato Market
  • Has sold $40,000+ on Envato Market
  • Located in Europe
  • Has been part of the Envato Community for over 3 years
+3 more
RafalBorowski says



2. About the wpautop – I know we cannot screw with the wp core but can we still filter for example our shortcodes to avoid p and br tags injection all over the theme?
No, you cannot do that. Those filters cause major compatibility problems with hundreds of plugins. I’ve personally lost 100s of support hours due to those filters. Utilize this instead: justintadlock.com/archives/2012/10/03/grid-columns-wordpress-plugin
No, they don’t if done right: https://gist.github.com/bitfade/4555047

Yes I am using this one – well not exactly word by word, but close enough. Hope it will be ok. I know that there are plugins for grid etc. but as someone already said why should I have to be forced to use someones plugin? Or even someones way of doing something HE think is right?

141 posts moutheme
  • Elite Author: Sold more than $75,000 on Envato Market
  • Has sold $125,000+ on Envato Market
  • Made it to the Authors' Hall of Fame
  • Had an item featured on Envato Market
+6 more
moutheme says

Try and tell me that building and maintaining your own contact form (just as an example) that is implemented separately in every theme you build is easier to update than supporting a plugin via just a few lines of CSS.

Forms and maps, twitter etc. – really good cases to use plugins. If you use them once you will feel its good thing. But I’m afraid these are only cases where it will work. And I’m imagine what it will be – part of the shortcodes in plugins, other part is in the theme – what is the point if we anyway will need custom theme shortcodes??? Its not possible to work without them, these rules are written by people who never create a theme with the current level of TF!

ThemeForest – you want your standards instead of creativity? Because I think its the most important thing in this marketplace. Why you try to apply the rules that are written for absolutely different situation?

3427 posts
  • Has sold $5,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Located in United States
  • Has been part of the Envato Community for over 4 years
+1 more
organicbee says




Also “The text domain parameter must be a string and not a variable or constant.” this is semi silly, there some cases where classes use a constant(filtered) to define the parameter so it can be reused. also there are a few theme frameworks that use a constant.
No, actually is must be a string. Setting it to a constant makes it not actually work.
hmm its working fine for me

Yes its working for manual translations bot not for automated, here is an article about it: link

But to be honest, we also didn’t know about it and used constants.

yup need to fix one of my classes, I only use it in part of my framework everything else is a string. I guess I never really though about automated as its all done manually

Helpful Information

  • Please read our community guidelines. Self promotion and discussion of piracy is not allowed.
  • Open a support ticket if you would like specific help with your account, deposits or purchases.
  • Item Support by authors is optional and may vary. Please see the Support tab on each item page.

Most of all, enjoy your time here. Thank you for being a valued Envato community member.

Post Reply

Format your entry with some basic HTML. Read the Full Details, or here is a refresher:

<strong></strong> to make things bold
<em></em> to emphasize
<ul><li> or <ol><li> to make lists
<h3> or <h4> to make headings
<pre></pre> for code blocks
<code></code> for a few words of code
<a></a> for links
<img> to paste in an image (it'll need to be hosted somewhere else though)
<blockquote></blockquote> to quote somebody

:grin: :shocked: :cry: Complete List of Smiley Codes

by
by
by
by
by
by