1587 posts
  • Has referred 50+ members
  • Has sold $125,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 100+ items on Envato Market
+5 more
Anps says

Just wanting to ask for e-commerce themes and if this is tested in review process?

Best regards

3610 posts Ruben Bristian
  • Sells items exclusively on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
  • Has sold $500,000+ on Envato Market
  • Has been part of the Envato Community for over 6 years
+10 more
KrownThemes says

What’s the difference between a theme on a normal server and a SSL server? There shouldn’t be anything in the theme to break, nor do you need any kind of special testing. Just make sure that you load static assets depending on the protocol and everything should work (but this is already a reviewer’s requirement).

1587 posts
  • Has referred 50+ members
  • Has sold $125,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 100+ items on Envato Market
+5 more
Anps says

Hehe we had this guy on support that claims that some plugin in our theme calls out to insecure content on the checkout page, not giving us any other info on it in the first mail just “Getting SSL errors for unsecured mixed content in Firefox and IE” and since he waited for 1 day and meanwhile solved the problem he went samurai on us :) and in the end told us that if we give him 5 licences for free to clone our theme to other domains he will share the solution with us :)

You learn new stuff every day don’t ya :)

3610 posts Ruben Bristian
  • Sells items exclusively on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
  • Has sold $500,000+ on Envato Market
  • Has been part of the Envato Community for over 6 years
+10 more
KrownThemes says

lol :D

What other solution than this?

$protocol = is_ssl() ? 'https' : 'http';
[...]
wp_enqueue_style( 'whatever', "$protocol://blahblahblah.css" );
1497 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Made it to the Authors' Hall of Fame
+2 more
OriginalEXE says
Why not just this?
wp_enqueue_style( 'whatever', '//blahblahblah.css' );
3610 posts Ruben Bristian
  • Sells items exclusively on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
  • Has sold $500,000+ on Envato Market
  • Has been part of the Envato Community for over 6 years
+10 more
KrownThemes says

^ Don’t know why, but i’ve encountered issues with this approach in the past.

1465 posts How's the surf doing?
  • Elite Author: Sold more than $75,000 on Envato Market
  • Has been part of the Envato Community for over 3 years
  • Had an item featured on Envato Market
  • Made it to the Authors' Hall of Fame
+6 more
tommusrhodus says

and in the end told us that if we give him 5 licences for free to clone our theme to other domains he will share the solution with us :)

You could consider reporting this user to Envato support, hopefully this was meant as a joke, but that’s basically extortion :|

EDIT: Not that he has to share the solution, but to offer it on terms that break various license terms on TF :)

1050 posts
  • Has sold $10,000+ on Envato Market
  • Has collected 50+ items on Envato Market
  • Has been a beta tester for an Envato feature
  • Contributed a free file of the month
+6 more
greenline says

There is a difference though with Google Maps API (most themes do display a map)

The link to non-secured (http) maps API is:
http://maps.googleapis.com/maps/api/js?sensor=false&v=3.exp

And the link to secured, SSL (https) maps API is:
https://maps-api-ssl.google.com/maps/api/js?sensor=false&v=3.exp

You can notice the difference.

Most people always use the first link to the API (the http one).

But then, when you access the website through a SSL connection (for instance if the website is an online shop), the browsers will display the message that the website is insecure and will ask you (the user) if you wish to display the non-secure content (the maps in this case)

To avoid that SSL warning, the themes should implement this differently:

if (is_ssl()) {
    wp_register_script('googlemapsapi', 'https://maps-api-ssl.google.com/maps/api/js?sensor=false&v=3.exp', array( 'jquery' ), null, true);
} else {
    wp_register_script('googlemapsapi', 'http://maps.googleapis.com/maps/api/js?sensor=false&v=3.exp', array( 'jquery' ), null, true);
}

1050 posts
  • Has sold $10,000+ on Envato Market
  • Has collected 50+ items on Envato Market
  • Has been a beta tester for an Envato feature
  • Contributed a free file of the month
+6 more
greenline says

I forgot to mention a very useful tool which shows a detailed report about what items are unsecured in your webpage: http://www.whynopadlock.com

3610 posts Ruben Bristian
  • Sells items exclusively on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
  • Has sold $500,000+ on Envato Market
  • Has been part of the Envato Community for over 6 years
+10 more
KrownThemes says
(most themes do display a map)

Most themes should embed maps (except when they are using custom maps). There is absolutely no purpose in adding another library to your theme just to load something which could be loaded via an external iframe.

Anyway, thanks for the tip. I am using custom maps in some themes and i didn’t knew that there is a difference in the ssl/non-ssl url.

by
by
by
by
by
by