152 posts
  • Exclusive Author
  • Has been a member for 4-5 years
partnuz says

I’m quite sure I’ve figured this out. Check this https://gist.github.com/partnuz/9175420 and tell me if there are any errors.

321 posts
  • Envato Studio (Microlancer) Beta Tester
  • Most Wanted Bounty Winner
  • Author had a File in an Envato Bundle
  • Has been a member for 5-6 years
  • Sold between 10 000 and 50 000 dollars
  • Exclusive Author
  • Bought between 10 and 49 items
  • Referred between 50 and 99 users
  • Romania
QBKL says

I’m quite sure I’ve figured this out. Check this https://gist.github.com/partnuz/9175420 and tell me if there are any errors.

No, it wouldn’t work. It manipulates the content of the shortcode in an undesirable way. First off, you’re replacing each and all P’s and BR’s with nothing… removing them. Maybe your user doesn’t want all BR’s removed? Cause that’s what he’ll get when his content will run through your function.

Consider a column shortcode. You’re basically forcing the user to drop all his paragraphs and line-breaks in that column, and not only from your shortcode, but also from other shortcodes he might use from different plugins.

This thing is annoying mostly when it comes to container-type of shortcodes as it breaks our beautifully measured layouts, paddings, margins… we need a viable solution for this.

Right now I’m considering two options: 1. Pack it with a switch in admin and warn users of the “Dangers” of activating it. 2. Drop the function in the documentation, again with a warning and let the user choose if they want to paste it or not in functions.php.

152 posts
  • Exclusive Author
  • Has been a member for 4-5 years
partnuz says

Maybe combining bitfade gist and using it inside shortcode should be better solution.

4145 posts Community Mod Building awesome stuff for your mobile devices!
  • Community Moderator
  • Elite Author
  • Sold between 100 000 and 250 000 dollars
  • Interviewed on the Envato Notes blog
  • Author had a Free File of the Month
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
  • Contributed a Tutorial to a Tuts+ Site
  • Won a Competition
+9 more
Enabled Volunteer moderator says

Hey guys! I’ve requested a Staff Reply for this thread, as it’s important for apparently all WP developers! Your patience is appreciated! :)

84 posts
  • Bought between 1 and 9 items
  • Exclusive Author
  • Has been a member for 3-4 years
  • Referred between 10 and 49 users
  • Sold between 50 000 and 100 000 dollars
Coffee-Themes says

Hey guys! I’ve requested a Staff Reply for this thread, as it’s important for apparently all WP developers! Your patience is appreciated! :)

Thanks!

2947 posts
  • Australia
  • Community Moderator
  • Elite Author
  • Author had a Free File of the Month
  • Most Wanted Bounty Winner
  • Author had a File in an Envato Bundle
  • Has been a member for 5-6 years
  • Contributed a Blog Post
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
+10 more
dtbaker Volunteer moderator says

Yes I’d love to see some real examples of why a solution such as bitfades is a bad thing? It fixes invalid code right? There is no possible way it can harm 3rd party plugins or mess with the layout of other content on the page? Or am I missing something here..

5 posts
  • Colombia
  • Exclusive Author
  • Has been a member for 3-4 years
  • Referred between 1 and 9 users
  • Bought between 10 and 49 items
  • Sold between 10 000 and 50 000 dollars
CondorThemes says

Hello guys,

I tried bitfade solution but it doesn’t work for me, i think one of the reason why this solution is being rejected is because people let the same function name “the_content_filter”, and all these functions should have a prefix, like “yourtheme_the_content_filter”.

Can you tell me where i can put this code? maybe in functions.php?

Thanks

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

Hey everyone,

Just to let you know, I’m currently discussing this with the review team, and will get back to you. Please be patient though, as it’s an important discussion, and it’s probably going to take longer than 5 minutes (particularly as a number of us are in different timezones).

Thank you! :)

321 posts
  • Envato Studio (Microlancer) Beta Tester
  • Most Wanted Bounty Winner
  • Author had a File in an Envato Bundle
  • Has been a member for 5-6 years
  • Sold between 10 000 and 50 000 dollars
  • Exclusive Author
  • Bought between 10 and 49 items
  • Referred between 50 and 99 users
  • Romania
QBKL says

Thank you Japh! Understandable considering the timezones. We do hope though it won’t take that long as it holds back authors’ projects around here.

Alex

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

Thank you Japh! Understandable considering the timezones. We do hope though it won’t take that long as it holds back authors’ projects around here.

Thanks, Alex. I’ll definitely keep that in mind, and do my best to speed things along.

by
by
by
by
by
by