119 posts
  • Attended a Community Meetup
  • Author had a File in an Envato Bundle
  • Bought between 50 and 99 items
  • Elite Author
  • Envato Staff
  • Exclusive Author
  • Has been a member for 5-6 years
+3 more
valendesigns Staff says

Found a BUG :

All the options that run a query, like page select or page checkbox, use the global posts_per_page setting, so not all the expected results are displayed.

The queries should set ‘posts_per_page’ => -1

In fact you use for all the queries:

‘numberposts’ => -1

but numberposts isn’t valid as argument… you should use posts_per_page instead of it.

Parker

Changed and pushed to the development branch.

3256 posts
  • Elite Author
  • Sold between 250 000 and 1 000 000 dollars
  • Exclusive Author
  • Interviewed on the Envato Notes blog
  • Beta Tester
  • Author had a File in an Envato Bundle
  • Author had a Free File of the Month
+4 more
ParkerAndKent says

Some deprecated stuff:

REQUIRED: ot-settings-api.php. Themes should use add_theme_page() for adding admin pages.

Line 88: $page_hook = add_menu_page( 

REQUIRED: get_settings found in the file ot-settings-api.php. Deprecated since version 2.1. Use get_option() instead.

Line 430: foreach( (array) $this->get_settings( $page ) as $setting ) {

Line 523: foreach( (array) $this->get_settings( $page ) as $setting ) {

Line 559: foreach( (array) $this->get_settings( $page ) as $setting ) {

Line 686: public function get_settings( $page = array() ) {

REQUIRED: class-tgm-plugin-activation.php. Themes should use add_theme_page() for adding admin pages.

Line 335: add_submenu_page(

REQUIRED: add_contextual_help found in the file ot-loader.php. Deprecated since version 3.3. Use get_current_screen()->add_help_tab() instead.

Line 236: add_action( 'wp_ajax_add_contextual_help', array( &$this, 'add_contextual_help' ) );

Line 290: public function add_contextual_help() {

Parker

119 posts
  • Attended a Community Meetup
  • Author had a File in an Envato Bundle
  • Bought between 50 and 99 items
  • Elite Author
  • Envato Staff
  • Exclusive Author
  • Has been a member for 5-6 years
+3 more
valendesigns Staff says

@ParkerAndKent

Thank you for looking into the deprecated functions. However, you’ve made some errors in your assessment on the functionality of the classes you’ve mentioned above.

Line 88: $page_hook = add_menu_page(

The add_theme_page() function is ONLY for adding a theme page, which is not the case here. The class can and does create other pages which are either top level or sub menu pages and ones that are not ONLY sub pages of the appearance page, and therefore requires a more broad approach to adding menu pages.

REQUIRED : get_settings found in the file ot-settings-api.php. Deprecated since version 2.1. Use get_option() instead.

This is not using a deprecated function it is calling a class method of the OT_Settings class. It is actually referencing $this->get_settings() not the WP function get_settings().

REQUIRED : class-tgm-plugin-activation.php. Themes should use add_theme_page() for adding admin pages.

OptionTree does not use that class, so I’m a bit confused about this reference.

REQUIRED : add_contextual_help found in the file ot-loader.php. Deprecated since version 3.3. Use get_current_screen()->add_help_tab() instead.

Again, this is calling the add_contextual_help() method of the OT_Loader class and has nothing to do with the get_current_screen()->add_help_tab() found in WP it is actually an AJAX helper method only used in the OT_Loader class.

I really do appreciate you looking over the plugin and trying to find deprecated functionality. However, to the best of my knowledge OptionTree is not using any such code.

Cheers, Derek

814 posts
  • Author had a Free File of the Month
  • Exclusive Author
  • Sold between 10 000 and 50 000 dollars
  • Bought between 1 and 9 items
  • Referred between 1 and 9 users
  • Serbia
  • Has been a member for 5-6 years
rvision_ says

Once again, Theme-check plugin shows how naive and stupid it is.

3256 posts
  • Elite Author
  • Sold between 250 000 and 1 000 000 dollars
  • Exclusive Author
  • Interviewed on the Envato Notes blog
  • Beta Tester
  • Author had a File in an Envato Bundle
  • Author had a Free File of the Month
+4 more
ParkerAndKent says

Hi Derek,

everything is clear. I’m testing in theme mode so I thought to show you these warnings (you know reviewers here don’t like these warnings). I know that theme check is a little “stupid”, but not knowing about your class methods, i thought you were using some WP core deprecated functions ;)

Cheers,

Parker

3256 posts
  • Elite Author
  • Sold between 250 000 and 1 000 000 dollars
  • Exclusive Author
  • Interviewed on the Envato Notes blog
  • Beta Tester
  • Author had a File in an Envato Bundle
  • Author had a Free File of the Month
+4 more
ParkerAndKent says

Once again, Theme-check plugin shows how naive and stupid it is.

+1 :)

119 posts
  • Attended a Community Meetup
  • Author had a File in an Envato Bundle
  • Bought between 50 and 99 items
  • Elite Author
  • Envato Staff
  • Exclusive Author
  • Has been a member for 5-6 years
+3 more
valendesigns Staff says

Hi Derek,

everything is clear. I’m testing in theme mode so I thought to show you these warnings (you know reviewers here don’t like these warnings). I know that theme check is a little “stupid”, but not knowing about your class methods, i thought you were using some WP core deprecated functions ;)

Cheers,

Parker

No worries, that plugin has some deficiencies, that’s for sure. It kind of sucks that it can’t distinguish between a regular function and a method of a class. Anyhow, it’s still good you brought it to my attention either way. Now at least if anyone says “you’re using deprecated functions” I can say with certainty it’s not. Finding these things early is good, thanks man!

119 posts
  • Attended a Community Meetup
  • Author had a File in an Envato Bundle
  • Bought between 50 and 99 items
  • Elite Author
  • Envato Staff
  • Exclusive Author
  • Has been a member for 5-6 years
+3 more
valendesigns Staff says

Hey Everyone, I’ve got two requests.

First, OptionTree 2.0rc3 is now available to download and test out https://github.com/valendesigns/option-tree

Second, I had a issue submitted on github by someone saying the textarea was not letting them save values. Can you verify it works for me, I can’t reproduce the issue so I’m a bit puzzled by it and I’d like to know if anyone else is having the same problem.

Thanks Guys, Derek

3256 posts
  • Elite Author
  • Sold between 250 000 and 1 000 000 dollars
  • Exclusive Author
  • Interviewed on the Envato Notes blog
  • Beta Tester
  • Author had a File in an Envato Bundle
  • Author had a Free File of the Month
+4 more
ParkerAndKent says

Hi Derek,

downloaded latest version, I have one textarea and it saves the new value. Not tested yet the metaboxes, so I’m talking about theme options in theme mode.

Parker

ps

In FF the “New Layout” button still is below the input field, while in IE9 the save button looks wierd ;)

119 posts
  • Attended a Community Meetup
  • Author had a File in an Envato Bundle
  • Bought between 50 and 99 items
  • Elite Author
  • Envato Staff
  • Exclusive Author
  • Has been a member for 5-6 years
+3 more
valendesigns Staff says

Hi Derek,

downloaded latest version, I have one textarea and it saves the new value. Not tested yet the metaboxes, so I’m talking about theme options in theme mode.

Parker

ps

In FF the “New Layout” button still is below the input field, while in IE9 the save button looks wierd ;)

If you don’t mind, could you please send screen shots to derek@valendesigns.com. Cheers!

by
by
by
by
by
by