621 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
ChapterThemes says



Talking about rejection reasons “The tracking code should be in the footer…” , now on google you can find this info: ”... each template page immediately after the opening body tag..” . So what is gonna be?
So that rejection reason is bull because lack of knowledge ‘bout google ( no offence to the reviewers )

According to devs @ google.com the Traditional Syntax “tracking code snippet should be included in your site’s pages so that it appears at the bottom of the page’s HTML (or generated-HTML) structure, before the closing tag.”

HTML5Boilerplate recommends to put it before as well.

So saying that our recommendation is because we lack knowledge about GA is not accurate.

@Sakura You added a textarea in your options so the user could insert their own GA code and although GA’s latest Asynchronous Syntax can be placed anywhere in the page what if they decide to use the Traditional Syntax?

Also please note that this was not your main rejection reason, you were using get_template_part() to call scripts and styles.

Your right indeed – but still some say header is best.

Funny thing is i always put in before closing body tag as well.. guess i was a bit off :)

621 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Sells items exclusively on Envato Market
ChapterThemes says

However I’m more concerned about the next phase of the process (starting November), moving CPTs to plugins, if you have a more creative theme (full screen) a portfolio plugin would work best with that theme, in order to make it compatible with any theme would require a lot more work.

Cheers!

Well, as far as i know that plugin doesnt need to be a fully working plugin inside other themes. I know it beats the purpose of a plugin. But the main reason is to just get functionality coding out of the theme, thus in a plugin – weither it works in other teams or not.

by
by
by
by
by
by