350 posts Gambit
  • 5 Years of Membership
  • Affiliate Level 2
  • Author Level 7
  • Collector Level 4
+6 more
bfintal
says

Okay I’ve got a question to the Envato staff

With regards to my current theme Dimension, I’ve dropped all shortcode support. People can still use them, but the theme does not come with shortcodes. It has a pagebuilder that users can use to put different types of content in. It makes it easier and faster to put content in without the hassle of remembering and typing in shortcodes and their attributes.

So the question is.. how does that factor in with the separation of theme vs plugins for phase 2? What do I do?

215 posts
  • Most Wanted Winner
  • Envato Pack
  • Author Level 5
  • Freebie
+4 more
EasyDevelopment
says


I’ve made a plugin which actually does something like that. http://codecanyon.net/item/wordpress-theme-controller/5529680?WT.ac=new_item&WT.seg_1=new_item&WT.z_author=easydevelopment

Now that’s usefull, especially for back-end users, the control for all visual features in one specific area.

I wonder if you already have or you think about implementing some features for like require/recommend plugin ( to replace TGM class).

I have a lot of ideas, but I don’t really have a reason to implement stuff if I don’t have any suporters, if people would actually start using this, I would enjoy implementing everything they would need.

138 posts
  • Affiliate Level 2
  • Author Level 7
  • Collector Level 3
  • Elite Author
+3 more
M-Theme
says

Hi, TF. Could please give us an example about this rule:

3.No hardcoded inline styles are allowed anywhere. Dynamic inline styles are permitted where necessary, and wp_add_inline_style() should be used where possible.

If it’s mean we can’t use the below code, why this theme(http://themeforest.net/item/the7-responsive-multipurpose-wordpress-theme/5556590) can be approved.

<div class="a" style="border: 1px solid red; color: #FFF;">
350 posts Gambit
  • 5 Years of Membership
  • Affiliate Level 2
  • Author Level 7
  • Collector Level 4
+6 more
bfintal
says

Hi, TF. Could please give us an example about this rule:
3.No hardcoded inline styles are allowed anywhere. Dynamic inline styles are permitted where necessary, and wp_add_inline_style() should be used where possible.

If it’s mean we can’t use the below code, why this theme(http://themeforest.net/item/the7-responsive-multipurpose-wordpress-theme/5556590) can be approved.

<div class="a" style="border: 1px solid red; color: #FFF;">

Haven’t checked the code of that theme. But it’s possible that that certain inline css is dynamic and generated from theme options or shortcode attributes

138 posts
  • Affiliate Level 2
  • Author Level 7
  • Collector Level 3
  • Elite Author
+3 more
M-Theme
says


Hi, TF. Could please give us an example about this rule:
3.No hardcoded inline styles are allowed anywhere. Dynamic inline styles are permitted where necessary, and wp_add_inline_style() should be used where possible.

Thanks bfintal! I hope TF can give us a reply. If it’s mean we can’t use the below code, why this theme(http://themeforest.net/item/the7-responsive-multipurpose-wordpress-theme/5556590) can be approved.

<div class="a" style="border: 1px solid red; color: #FFF;">
Haven’t checked the code of that theme. But it’s possible that that certain inline css is dynamic and generated from theme options or shortcode attributes

Thanks bfintal, I hope TF can give us a reply also.

6 posts
  • 4 Years of Membership
  • Collector Level 2
  • Exclusive Author
lup
says

Hi, TF. Could please give us an example about this rule:
3.No hardcoded inline styles are allowed anywhere. Dynamic inline styles are permitted where necessary, and wp_add_inline_style() should be used where possible.

If it’s mean we can’t use the below code, why this theme(http://themeforest.net/item/the7-responsive-multipurpose-wordpress-theme/5556590) can be approved.

<div class="a" style="border: 1px solid red; color: #FFF;">

I think this rule tries to prevent the use of <style> tag, hardcoded, in themes. It may be applied for element style, but there are lots cases when you need to modify the css dinamically(look at flexslider or any jquery animation ).

1642 posts
  • Elite Author
  • Featured Author
  • 6 Years of Membership
  • Author Level 10
+8 more
fuelthemes
says

Well avada has about 1000 lines of inline code then :D

view-source:http://theme-fusion.com/avada/

954 posts
  • Affiliate Level 1
  • Author Level 3
  • Beta Tester
  • Most Wanted Winner
+3 more
aleluja
says

It’s called embedded css when you put in <style>...</style> and inline when it’s an attribute of an HTML element (style=”...”)

3535 posts
  • Power Elite Author
  • Author Level 12
  • Trendsetter
  • United States
+13 more
sevenspark
Moderator
says

Guys, while the discussion is great, please respect the forum rules and avoid calling out specific themes. Thanks! :)

352 posts Premium Website Design
  • Top Monthly Author
  • Trendsetter
  • United States
  • Weekly Top Seller
+7 more
ThemeFusion
says

Difference is dynamic inline CSS vs static hardcoded inline CSS.

Anyways, this is a much better method http://codex.wordpress.org/Function_Reference/wp_add_inline_style which we are going to change to soon enough.

by
by
by
by
by
by