366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

Thank you Japh for your great effort for clarification :) I have one question.

Why “page builders” are allowed in the theme? ( phase 2)

If buyer will switch to any other theme then all content added via “page builder” will not work in another theme.

This is an interesting one, and I’d like to discuss it further, perhaps in a separate thread as I imagine it’s a contentious issue that a lot of you will have thoughts on.

Some of you seem happy with this being in a plugin, and some are very much not happy with that idea.

88 posts
  • Sold between 1 000 and 5 000 dollars
  • Has been a member for 3-4 years
  • Bought between 1 and 9 items
  • Exclusive Author
DesignPuma says

@Japh I am currently develop my new wp framework. I want this framework to be compatible with the new wp themeforest standards before upload my first wp item (about 2-3 weeks). Can anybody make small review onto my framework (you, reviewer or some another tf staff)? This will be very helpful for me. :)

Thanks!

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

I have good feeling about Themeforest marketplace since Envato hired you, good move Japh :D

You’re too kind! :)


Anyway, how about theme customizer http://codex.wordpress.org/Theme_Customization_API Does this feature should be on theme or plugin?

This should be in the theme. In fact, this is a great way to do any visual options for a theme.

101 posts
  • Australia
  • Bought between 1 and 9 items
  • Exclusive Author
  • Has been a member for 4-5 years
  • Referred between 1 and 9 users
  • Sold between 1 000 and 5 000 dollars
pjtops says

At the moment, we’re not requiring that the entire set of PHP coding rules, as outlined for WordPress, be followed. We’re specifying a couple of them that we do require in order to improve legibility of code. If it would be easier for you to simply follow them wholesale though, then by all means, please do!

The tabs one is a bit tricky, as wordpress does it differently from most other big PHP projects. I’m seeing a situation where I’ll have to adjust my editor every time when switching between creating themes/plugins for here, and working on other projects. If its about legibility, then how about a compromise, like for indenting, use 1 tab OR 4 spaces. Unless of-course you do plan to require full compliance to the wordpress style-guide, then it doesn’t really matter what rules you choose to start with.

114 posts
  • Elite Author
  • Sold between 100 000 and 250 000 dollars
  • Exclusive Author
  • Bought between 100 and 499 items
  • Referred between 50 and 99 users
  • Most Wanted Bounty Winner
  • Envato Studio (Microlancer) Beta Tester
  • Has been a member for 2-3 years
nagaemas says


Thank you Japh for your great effort for clarification :) I have one question.

Why “page builders” are allowed in the theme? ( phase 2)

If buyer will switch to any other theme then all content added via “page builder” will not work in another theme.

This is an interesting one, and I’d like to discuss it further, perhaps in a separate thread as I imagine it’s a contentious issue that a lot of you will have thoughts on.

Some of you seem happy with this being in a plugin, and some are very much not happy with that idea.

Yes, I don’t think that page builders should be in theme, as that doesn’t make sense actually since shortcodes should be placed inside plugins and page builder completely depends on shortcodes (Visual Composer as a very successful plugin do that). If the shortcode plugin is deactivated, the page builder will not work anymore so it’s better not to put it into the theme.

32 posts
  • Bought between 10 and 49 items
  • Exclusive Author
  • Has been a member for 1-2 years
  • Sold between 100 and 1 000 dollars
  • Sweden
Deveraux says

Yes, I don’t think that page builders should be in theme, as that doesn’t make sense actually since shortcodes should be placed inside plugins and page builder completely depends on shortcodes (Visual Composer as a very successful plugin do that). If the shortcode plugin is deactivated, the page builder will not work anymore so it’s better not to put it into the theme.

Visual Composer wouldn’t be able to be usable if that goes through with the current licencing. If you buy an extended licence it’s for one theme.

1549 posts
  • Bought between 1 and 9 items
  • Europe
  • Exclusive Author
  • Has been a member for 6-7 years
  • Referred between 100 and 199 users
  • Sold between 50 000 and 100 000 dollars
dSKY says

Question about JavaScript files.
You stated “Authors are not allowed to deregister the default version of jQuery and load another one.”
Am I allowed to deregister the local, and load the same version via cdn?

- Another one
” If a CDN version of a library is included, a local copy must be provided as a fallback. “

If I’m loading a well known library via cdn , should I also include a local copy in the download files and that’s it, or there are some additional steps that must be taken to comply for that rule?

366 posts WordPress Guy
  • Envato Staff
  • Australia
  • Has been a member for 5-6 years
  • Contributed a Tutorial to a Tuts+ Site
  • Exclusive Author
  • Sold between 100 and 1 000 dollars
  • Bought between 50 and 99 items
  • Referred between 1 and 9 users
  • Repeatedly Helped protect Envato Marketplaces against copyright violations
Japh Staff says

Question about JavaScript files.
You stated “Authors are not allowed to deregister the default version of jQuery and load another one.”
Am I allowed to deregister the local, and load the same version via cdn?

There’s really no need to do this, and it creates an additional unnecessary dependency.


- Another one
” If a CDN version of a library is included, a local copy must be provided as a fallback. ” If I’m loading a well known library via cdn , should I also include a local copy in the download files and that’s it, or there are some additional steps that must be taken to comply for that rule?

When we say provide a local copy as fallback, we mean using a mechanism that automatically falls back to the local copy if the CDN copy fails to load. Not simply providing it with the download package.

32 posts
  • Bought between 10 and 49 items
  • Exclusive Author
  • Has been a member for 1-2 years
  • Sold between 100 and 1 000 dollars
  • Sweden
Deveraux says

One of the things that kind of worries me with moving everything to plugins, is that if something breaks in one plugin because of naming convention for example, the site will become unusable. Even with a unique prefix, there are quite a few authors here, and if there’s a couple of themes installed, I think that naming conflicts will be an issue. Maybe a larger problem then what you’ll anticipate…

And then there’s always an issue of pageload times. With an increasing amount of plugins and shortcodes in plugins, the_content() will eventually start running very slowly, since there’s quite a bit of regex involved.

33 posts
  • Bought between 1 and 9 items
  • Exclusive Author
  • Has been a member for 2-3 years
  • United States
JonnyShogun says


Your themecheck plugin doesn’t supress the usage of cURL. Is that intended?
Yes, that is intended. Instead of using cURL, you should use WordPress’ wp_remote_request() function.

What about the new Twitter API oAuth.. it uses curl. So what do we do about that since the new Twitter API since in order to use the new twitter requests, you must use there new API oAth files. You have to setup a Twitter developer app to use with the new Twitter APi which uses curl. So will this be a problem???

by
by
by
by
by
by