500 posts
  • Sells items exclusively on Envato Market
  • Has sold $10,000+ on Envato Market
  • Won a competition
  • Won a Most Wanted contest
+4 more
pixeful says

Got a SOFT reject of template that is based on same framework only as I would say changed a layout view. Last time template was accepted without any changes and rejections, but this time same framework got so much stuff to change:

Enqueue the Google fonts the right way https://gist.github.com/ivorpad/b5cff9c3d597d2764295

Uncaught Error: Syntax error, unrecognized expression: #http://localhost/wordpress/new-page/ jquery-1.9.1.js?ver=1.9.1:4421

It’s a very poor practice to deregister WordPress’ built-in jQuery and load another specific version. Please use the WordPress default javascript library.

Use the jQuery noConflict mode to avoid issues — http://codex.wordpress.org/Function_Reference/wp_enqueue_script#jQuery_noConflict_wrappers

JavaScript files need to be placed at the bottom, barring critical exclusion. [Modernizr, for instance] You can do this with the $in_footer argument of wp_enqueue_script.

Please make sure that you’re not using any deprecated WP tags. You can use the theme check plugin to check for this. Also, make sure that your template doesn’t raise any PHP errors, notices or warnings. Enabling wp_debug can help you with this. Please make sure that the default WordPress CSS classes are covered in your stylesheet and you’re not stripping out any native functionality.

Install http://wordpress.org/extend/plugins/developer as “Theme for a self-hosted WordPress installation”, and let it install the following debug tools: - Debug Bar - Debug Bar Cron - Log Deprecated Notices - Monster Widget - Theme Check

Make sure all the WP default widgets display properly in all widgetized areas.

http://d.pr/i/TBSW http://d.pr/i/ilue

wp_head should be placed immediately before head closing tag.

put this in external js file – http://d.pr/i/8LKU

Please use wp_enqueue to load any external scripts/stylesheet – wp_enqueue_script / wp_enqueue_style – http://codex.wordpress.org/Function_Reference/wp_enqueue_script#Functions

Also, please use conditional tag to load scripts for only the specific page, for example nivo script only for page with nivo slider.

Biggest problem right now is: It’s a very poor practice to deregister WordPress’ built-in jQuery and load another specific version. Please use the WordPress default javascript library.

How can I sort that? That if I use 1.9 – everything is ok… if I should use: 1.10.2 – everything stops working. Why should I do this way?

1479 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Made it to the Authors' Hall of Fame
+3 more
OriginalEXE says

If everything stops working on 1.10.2 you should really question your code.

It’s bad practice to deregister jQuery and load your own version because I as a WordPress developer, whose product might be installed besides yours on some WP page, need to know that if I detect WordPress version X, that there will be jQuery version Y in use.

http://pippinsplugins.com/why-loading-your-own-jquery-is-irresponsible/
426 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 50+ items on Envato Market
  • Sells items exclusively on Envato Market
+2 more
SimpleSites4U says

I gotta agree, overriding WPs built in jquery causes so many headaches

dont forget your theme will need to place nice with plugins and such

2207 posts
  • Has referred 1+ members
  • Has sold $10,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 10+ items on Envato Market
+4 more
manuelvega says

Yes i had to correct all this things some times :P

1289 posts How's the surf doing?
  • Has referred 200+ members
  • Has sold $500,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 10+ items on Envato Market
+6 more
tommusrhodus says

Biggest problem right now is: It’s a very poor practice to deregister WordPress’ built-in jQuery and load another specific version. Please use the WordPress default javascript library. How can I sort that? That if I use 1.9 – everything is ok… if I should use: 1.10.2 – everything stops working. Why should I do this way?

That’s not an excuse to ignore standards, if your .js isn’t working properly then your theme shouldn’t be available for commercial sale anyway, fix your .js and then enqueue jQuery to correct way. This will also mean less issues for your future buyers also.

472 posts
  • Has referred 50+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 1+ items on Envato Market
  • Made it to the Authors' Hall of Fame
+3 more
phpbits says

You should follow the standards, that’s the reason why they implement that ;). I remember one of my buyer who says my plugin isn’t working and rate it as 1 star but when I asked for login and site link I’ve noticed that the issue was the theme jquery version. It sucks that the wrong implementation for the theme affects my item, just sayin’

Cheers!

472 posts
  • Has referred 50+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 1+ items on Envato Market
  • Made it to the Authors' Hall of Fame
+3 more
phpbits says

You should follow the standards, that’s the reason why they implement that ;). I remember one of my buyer who says my plugin isn’t working and rate it as 1 star but when I asked for login and site link I’ve noticed that the issue was the theme jquery version. It sucks that the wrong implementation for the theme affects my item, just sayin’

Cheers!

500 posts
  • Sells items exclusively on Envato Market
  • Has sold $10,000+ on Envato Market
  • Won a competition
  • Won a Most Wanted contest
+4 more
pixeful says

You should follow the standards, that’s the reason why they implement that ;). I remember one of my buyer who says my plugin isn’t working and rate it as 1 star but when I asked for login and site link I’ve noticed that the issue was the theme jquery version. It sucks that the wrong implementation for the theme affects my item, just sayin’ Cheers!

That’s just then explains! Thanks buddy!

472 posts
  • Has referred 50+ members
  • Has sold $10,000+ on Envato Market
  • Has collected 1+ items on Envato Market
  • Made it to the Authors' Hall of Fame
+3 more
phpbits says


You should follow the standards, that’s the reason why they implement that ;). I remember one of my buyer who says my plugin isn’t working and rate it as 1 star but when I asked for login and site link I’ve noticed that the issue was the theme jquery version. It sucks that the wrong implementation for the theme affects my item, just sayin’ Cheers!
That’s just then explains! Thanks buddy!

No problem ;)

500 posts
  • Sells items exclusively on Envato Market
  • Has sold $10,000+ on Envato Market
  • Won a competition
  • Won a Most Wanted contest
+4 more
pixeful says

How to fix that?

WARNING: .fuse_hidden0000002700000001 Hidden Files or Folders found. RECOMMENDED: Screenshot size should be 600×450, to account for HiDPI displays. Any 4:3 image size is acceptable, but 600×450 is preferred. RECOMMENDED: image_resize found in the file functions/aq_resizer.php. Deprecated since version 3.5. Use wp_get_image_editor() instead. Line 18: * @uses image_resize_dimensions() | image_resize() Line 30: if ( true === $upscale ) add_filter( ‘image_resize_dimensions’, ‘aq_upscale’, 10, 6 ); Line 66: $dims = image_resize_dimensions( $orig_w, $orig_h, $width, $height, $crop ); Line 111: $resized_img_path = image_resize( $img_path, $width, $height, $crop ); // Fallback foo. Line 125: if ( true === $upscale ) remove_filter( ‘image_resize_dimensions’, ‘aq_upscale’ );

by
by
by
by
by
by