3439 posts
  • Author Level 4
  • Collector Level 2
  • Community Superstar
  • United States
+2 more
organicbee
says

a jquery plugin uses poor html for example a plugin im using for a gallery wants the code to look like

<div id=""> 
<a href="#"><img title="Title" src="images/ss_image_01.jpg" /></a>
<a href="#"><img title="Title" src="images/ss_image_02.jpg" /></a>
<a href="#"><img title="Title" src="images/ss_image_03.jpg" /></a>
<a href="#"><img title="Title" src="images/ss_image_04.jpg" /></a>
</div>

but id prefer it to be in a ul tag Ive been messing with the plugin to try and get it to work but it just screws it up more

1141 posts
  • 5 Years of Membership
  • Affiliate Level 1
  • Author Level 6
  • Collector Level 4
+3 more
KarmaThemes
says

I don’t understand what your thread has to do with the thread title, what is your question?

Greetings, GC

RocketshipThemes
RocketshipThemes Recent Posts Threads Started
360 posts
  • Author Level 5
  • Featured Item
  • 5 Years of Membership
  • United Kingdom
+3 more
RocketshipThemes
says
I don’t understand what your thread has to do with the thread title, what is your question? Greetings, GC

I think what OrganicBeeMedia is trying to say is, the correct way to code that piece above would be to put it in a ul but the plugin won’t allow it. So would a theme be rejected as it uses ‘incorrect’ markup if you like?

I’m not sure, I would say no but your guess is as good as mine unless a reviewer will let us know.

2468 posts
  • 6 Years of Membership
  • Author Level 2
  • Affiliate Level 4
  • Beta Tester
+3 more
digitalimpact
says

If I were a buyer looking at such a theme, I’d worry more about having alt tags on those images, instead of code semantics. I don’t think it’s poor HTML , it will validate and I don’t see a reason to reject a theme because of this.

However, is it that hard to modify that plugin to output an ul with list items for each slide? If you manage it, if I were you I’d go the extra mile and adjust it myself ;)

EDIT : what plugin are you working with?

815 posts
  • Affiliate Level 1
  • Author Level 5
  • Collector Level 1
  • Freebie
+3 more
rvision_
says
a jquery plugin uses poor html for example a plugin im using for a gallery wants the code to look like
  




 

but id prefer it to be in a ul tag Ive been messing with the plugin to try and get it to work but it just screws it up more

Code it in unordered list, and use jquery to unwrap the elements and make html suitable for the plugin.

1950 posts Do the Needful
  • Weekly Top Seller
  • Author Level 8
  • Elite Author
  • 5 Years of Membership
+12 more
JamiGibbs
says

As long as it validates, I don’t see how it would relate to your theme being rejected because of it.

319 posts
  • Weekly Top Seller
  • Exclusive Author
  • Elite Author
  • Featured Author
+9 more
bitpub
says

I have had a case when i was asked to modify a slider script to get the code used to be more semantic.

The code you listed above would only make sense to be transformed in an unsorted list and I think that there is a good chance that you will be asked to do so.

590 posts
  • Weekly Top Seller
  • Elite Author
  • Author Level 8
  • Featured Author
+6 more
CodeSwift
says

Yes, Your template/theme will be rejected. Usually I use a UL list for all kind of lists. But did code something like the way you placed up here and that was a reason to reject my site template.

137 posts Ahoy, me Hearties!
  • Trendsetter
  • Weekly Top Seller
  • Elite Author
  • Featured Author
+7 more
ChrisMooney
says

I believe Jeffrey Way did address this in a forum post a couple of months back. Back when I started out my template was rejected for such an issue.

3007 posts
  • 5 Years of Membership
  • Affiliate Level 5
  • Author Level 9
  • Bundle Boss
+8 more
duotive
says
best way:

<ul id=""> 
    <li>
        <a href="#" title="here goes your title">
            <img title="Title" src="images/ss_image_01.jpg" alt="here goes your alt" />
        </a>
    </li>  
    <li>
        <a href="#" title="here goes your title">
            <img title="Title" src="images/ss_image_01.jpg" alt="here goes your alt" />
        </a>
    </li> 
    <li>
        <a href="#" title="here goes your title">
            <img title="Title" src="images/ss_image_01.jpg" alt="here goes your alt" />
        </a>
    </li> 
    <li>
        <a href="#" title="here goes your title">
            <img title="Title" src="images/ss_image_01.jpg" alt="here goes your alt" />
        </a>
    </li>               
</ul>


by
by
by
by
by
by