478 posts WordPress Gurus!
  • Has referred 200+ members
  • Has sold $125,000+ on Envato Market
  • Has collected 50+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+3 more
ThemeBeans says

Also you could use .logged-in.admin-bar .header { top: 32px; } to target specific elements when theres a conflict. Just an example :)

110 posts
  • Has collected 10+ items on Envato Market
  • Has been part of the Envato Community for over 1 year
  • Sells items exclusively on Envato Market
  • Located in Europe
themespirit says

For the Admin Bar overlap issue, add…

<?php body_class ( ) ; ?> into your opening body tag.

<body <HERE>>

Then in your css, add…

.admin-bar .navbar-fixed-top { margin-top: 36px; }

Note: Replace navbar-fixed-top with whatever your navbar or header class is.

Not sure if this is the correct way for TF but it’s what they teach on TeamTreehouse

1139 posts
  • Has referred 50+ members
  • Has sold $40,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 50+ items on Envato Market
+5 more
Smartik says
For admin bar I agree. You must avoid any conflicts with the theme design and as other said, there too many methods to fix this. I’ll add one more:
if ( is_admin_bar_showing() ) {
    // do something
}
364 posts Design Innovation
  • Elite Author: Sold more than $75,000 on Envato Market
  • Has sold $250,000+ on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has been part of the Envato Community for over 2 years
+4 more
designova says

Thank you all for the suggestions.

We have fixed all the issues except the ”!important” rule. The reviewer have send us a link http://css-tricks.com/when-using-important-is-the-right-choice/ to fix this. But we are not able find a better solution.

We hope someone can provide some guidelines. If Ivor / Kailoon provide a kind response, it will be very helpful to us.

Thank you everyone

Cheers! Team Designova

364 posts Design Innovation
  • Elite Author: Sold more than $75,000 on Envato Market
  • Has sold $250,000+ on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has been part of the Envato Community for over 2 years
+4 more
designova says

“I use !important when a plugin styling is over riding my CSS (and the plugin CSS is quite specific) my thought process is that altering it in my CSS will save it being removed when the plugin is updated.”

Is there a better way to do this?

166 posts
  • Won a Most Wanted contest
  • Had an item featured in an Envato Pack
  • Has sold $5,000+ on Envato Market
  • Contributed a free file of the month
+5 more
EasyDevelopment says

2. Admin bar overlap: http://envato.d.pr/L3zZ/4FqfhLpo

If the admin bar exists, the body has the “admin-bar” class, all you have to do is create a new css rule,

.admin-bar > .my-menu-patch.fixed { top:32px; }

199 posts
  • Has referred 200+ members
  • Has sold $500,000+ on Envato Market
  • Has collected 50+ items on Envato Market
  • Attended one of our Meetups around the world
+4 more
themeva says

Thank you all for the suggestions.

We have fixed all the issues except the ”!important” rule. The reviewer have send us a link http://css-tricks.com/when-using-important-is-the-right-choice/ to fix this. But we are not able find a better solution.

We hope someone can provide some guidelines. If Ivor / Kailoon provide a kind response, it will be very helpful to us.

Thank you everyone

Cheers! Team Designova

I’m interested to know what the outcome of this is too!

Reading that article, it suggests that it’s okay to use the !important rule on specific elements you want to stay rigid. e.g.

BAD USE a { color:#333 !important; }

GOOD USE .my-element a {color:#333 !important;}

61 posts MeanThemes
  • Elite Author: Sold more than $75,000 on Envato Market
  • Had an item featured on Envato Market
  • Has sold $125,000+ on Envato Market
  • Won a competition
+7 more
meanthemes says

If a plugin is causing an issue, you can always use…

body .pluginclass { color: red; }

That is usually a simple way of removing the need for an !important.

364 posts Design Innovation
  • Elite Author: Sold more than $75,000 on Envato Market
  • Has sold $250,000+ on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has been part of the Envato Community for over 2 years
+4 more
designova says

If a plugin is causing an issue, you can always use… body .pluginclass { color: red; } That is usually a simple way of removing the need for an !important.

Yep that’s okay. But some JS plugins generate CSS on run-time. In order to over-ride these styles ’!important’ comes handy, isn’t it allowed? This brings some confusion now.

364 posts Design Innovation
  • Elite Author: Sold more than $75,000 on Envato Market
  • Has sold $250,000+ on Envato Market
  • Made it to the Authors' Hall of Fame
  • Has been part of the Envato Community for over 2 years
+4 more
designova says

We removed most of the !important rules and now the theme has been approved :) thank you everyone for your response on this thread. Thank you so much Ivor and review team.

by
by
by
by
by
by