Reviewers should just reject themes that includes tonnes of shortcode integrated into their themes. I know I did this too in all my recent themes, so I’m not trying to be hypocrite here – but i’ve included only enough so that users won’t complain about the theme not having any.
If reviewers can just be more strict about this, for the sake of WP best practice, we can all be happy and remove any shortcodes we have in our themes (or turn it into a plugin instead).
I agree with you pretty much. I have seen the trend on the themeforest that authors often include so much useless and unnecessary features (not only shortcodes) to their themes just because other themes have it. But at the end, I guess its author’s own choice.
even if they decide to add unnecessary shortcodes it should always be on a plugin so when the theme changes youre not left with brackets everywhere
I ditched shortcodes in my latest two themes, as I realized I’ve been doing it wrong the whole time.
The response from my customers to ditching shortcodes was awesome!
Can somebody point me to the “bad” example? Thanks!
yes, i think there should be a standard class/plugin with some predefined basic shortcodes which every themeforest author should/could use and style according to overall styling of their themes.
IMO , a unique plugin developed by the author, shipped with the theme files and works well with other themes will be enough.
I quit putting shortcodes in my themes also. The only shortcodes I have on my theme are a login/logout link, query counter for load speed testing, display the site link, display the site title, display the year, display a link to wordpress.org, display a nav menu, and a slideshow for gallery post types.
I also just create plugins when I need a custom post type, keeps things more organized and makes it easier to update. The most basic of html elements shouldn’t even be made into a shortcode. I even thought of making my own shortcode plugin but many already exists.
The only reason shortcodes are needed is because authors are trying to compete with other authors. It’s just a race to see who can add the most features.
I’ve been in the WordPress theme business longer than most (since 2008) and have never needed to resort to such measures. I’ve also never had a user ask me for such shortcodes, but that’s really besides the point. We all know the reasons it’s wrong to add shortcodes for use in post content to themes, so I won’t go over them. But, until the reviewers (or whoever controls this process) outright ban this sort of thing in themes, we’ll keep having this conversation.
It makes it hard for theme authors who follow standards and best practices to compete with theme authors who are not following those same standards and practices. Envato is promoting this by not stepping in and doing anything about it. It’s a disservice not only to the theme authors here but to the users who spend their money here.
As I’ve said before, I’ll be more than happy to code the plugins needed to help in this area and release them for free (as I’ve already shown with my [column] shortcode plugin). I’m offering my services free of charge to this community and the greater WordPress community.
Can somebody point me to the “bad” example? Thanks!
All shortcodes designed to be added to post/page content are bad practice assuming they’re added to a theme instead of a plugin.
- Microlancer Beta Tester
- Sold between 250 000 and 1 000 000 dollars
- Author was Featured
- Item was Featured
- Has been a member for 4-5 years
- Author had a File in an Envato Bundle
- Referred between 200 and 499 users
- Author had a Free File of the Month
If you take a look at the popular list for WordPress you’ll see the themes that are killing it in sales include a TON of shortcodes. If that’s what buyers want that’s what you should supply them, at the end of the day this is a business.
If you don’t supply what they want, then most likely you’re going to see little to no sales at the end of the day.
