I have one version.Maybe reviewer think that my theme provide custom sidebar feature like in Total theme. http://wpexplorer-themes.com/total/docs/custom-sidebars-advanced/
He call it “Custom widget area”.
My theme provide similar feature but not register sidebar with name which can make conflicts with plugins.
This is surprise for me that “Custom widget area” is established term which mean sidebar which defined by user via admin panel. I thought this is not popular feature.
I found this text for layers framework, but it not help to understandhttps://help.market.envato.com/hc/en-us/articles/204444934-Layers-WordPress-Child-Theme-Submission-Requirements
<?php if (is_active_sidebar('sidebar')) : ?> <div id="tertiary" class="sidebar-container" role="complementary"> <div class="sidebar-inner"> <div class="widget-area clearfix"> <?php dynamic_sidebar('sidebar'); ?> </div><!— .widget-area —> </div><!— .sidebar-inner —> </div><!— #tertiary —> <?php endif; ?>
maybe reviewer mean some other issue. i am not understand – i did it like you said.
Reviewer give comment:
2. Custom widget areas must use the safety condition “is_active_sidebar” to ensure no naming conflict with other plugins. https://codex.wordpress.org/Function_Reference/is_active_sidebar
But in all places where I call dynamic_sidebar I wrap it by is_active_sidebar exactly as in codex. I note it to reviewer but he just repeat this comment again. I am not understand what he mean.
Can someone help ?
Very cool theme.
But I think it need small fixes. 1. Header in some cases is hanging. 2. Not have clear sense that the post ended and the next began in post list.