Posts by azexo

31 posts
  • Elite Author
  • Author Level 8
  • Trendsetter
  • Affiliate Level 2
+3 more
azexo
says

I have one version.

Maybe reviewer think that my theme provide custom sidebar feature like in Total theme. http://wpexplorer-themes.com/total/docs/custom-sidebars-advanced/

He call it “Custom widget area”.

My theme provide similar feature but not register sidebar with name which can make conflicts with plugins.

This is surprise for me that “Custom widget area” is established term which mean sidebar which defined by user via admin panel. I thought this is not popular feature.

31 posts
  • Elite Author
  • Author Level 8
  • Trendsetter
  • Affiliate Level 2
+3 more
azexo
says
31 posts
  • Elite Author
  • Author Level 8
  • Trendsetter
  • Affiliate Level 2
+3 more
azexo
says

never face this problem, but you may need to check is_active_sidebar before register a sidebar?

Maybe. I did not do it. I checked few other themes they not do it. Maybe this is new requirement from TF

31 posts
  • Elite Author
  • Author Level 8
  • Trendsetter
  • Affiliate Level 2
+3 more
azexo
says
i use code like this:
<?php if (is_active_sidebar('sidebar')) : ?>
<div id="tertiary" class="sidebar-container" role="complementary">
<div class="sidebar-inner">
<div class="widget-area clearfix">
<?php dynamic_sidebar('sidebar'); ?>
</div><!— .widget-area —>
</div><!— .sidebar-inner —>
</div><!— #tertiary —>
<?php endif; ?>

maybe reviewer mean some other issue. i am not understand – i did it like you said.

31 posts
  • Elite Author
  • Author Level 8
  • Trendsetter
  • Affiliate Level 2
+3 more
azexo
says

Reviewer give comment:

2. Custom widget areas must use the safety condition “is_active_sidebar” to ensure no naming conflict with other plugins. https://codex.wordpress.org/Function_Reference/is_active_sidebar

But in all places where I call dynamic_sidebar I wrap it by is_active_sidebar exactly as in codex. I note it to reviewer but he just repeat this comment again. I am not understand what he mean.

Can someone help ?

31 posts
  • Elite Author
  • Author Level 8
  • Trendsetter
  • Affiliate Level 2
+3 more
azexo
says
http://azexo.com/light

Can anyone say what is the main issue in my theme ?

Many thanks!

31 posts
  • Elite Author
  • Author Level 8
  • Trendsetter
  • Affiliate Level 2
+3 more
azexo
says

Very cool theme.

But I think it need small fixes. 1. Header in some cases is hanging. 2. Not have clear sense that the post ended and the next began in post list.

31 posts
  • Elite Author
  • Author Level 8
  • Trendsetter
  • Affiliate Level 2
+3 more
azexo
says

I am willing to negotiate the 50/50 terms.

31 posts
  • Elite Author
  • Author Level 8
  • Trendsetter
  • Affiliate Level 2
+3 more
azexo
says

I am willing to negotiate the 50/50 terms.

31 posts
  • Elite Author
  • Author Level 8
  • Trendsetter
  • Affiliate Level 2
+3 more
azexo
says

I am willing to negotiate the 50/50 terms.

by
by
by
by
by
by